Skip to content

fix: Disable non-browser environments session tracking in @sentry/browser#3194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kamilogorek merged 2 commits into from
Jan 22, 2021
Merged

fix: Disable non-browser environments session tracking in @sentry/browser #3194

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c3385d1
fix: Disable non-browser enviornments session tracking in @sentry/bro…
kamilogorek Jan 22, 2021
645027f
Merge branch 'master' into disable-non-browser-session-tracking
kamilogorek Jan 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion packages/browser/src/sdk.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
import { getCurrentHub, initAndBind, Integrations as CoreIntegrations, SDK_VERSION } from '@sentry/core';
import { addInstrumentationHandler, getGlobalObject, SyncPromise } from '@sentry/utils';
import { addInstrumentationHandler, getGlobalObject, logger, SyncPromise } from '@sentry/utils';

import { BrowserOptions } from './backend';
import { BrowserClient } from './client';
Expand DownExpand Up@@ -192,6 +192,13 @@ export function wrap(fn: (...args: any) => any): any {
*/
function startSessionTracking(): void {
const window = getGlobalObject<Window>();
const document = window.document;

if (typeof document === 'undefined') {
logger.warn('Session tracking in non-browser environment with @sentry/browser is not supported.')
return;
}

const hub = getCurrentHub();

/**
Expand Down