Skip to content

fix(tracing): Avoid browser tracing initialization on node environment. - #3548

Merged
AbhiPrasad merged 5 commits into
masterfrom
fix/tracing-avoid-ssr
May 19, 2021
Merged

fix(tracing): Avoid browser tracing initialization on node environment.#3548
AbhiPrasad merged 5 commits into
masterfrom
fix/tracing-avoid-ssr

Conversation

@onurtemizkan

Copy link
Copy Markdown
Contributor

Fixes#3522
Related: nodejs/node#37970

@onurtemizkanonurtemizkan changed the title fix: Avoid tracing initialization on node environment.fix(tracing): Avoid tracing initialization on node environment.May 15, 2021
@onurtemizkanonurtemizkan changed the title fix(tracing): Avoid tracing initialization on node environment.fix(tracing): Avoid browser tracing initialization on node environment.May 15, 2021
@github-actions

github-actionsBot commented May 15, 2021

Copy link
Copy Markdown
Contributor

size-limit report

PathSize
@sentry/browser - CDN Bundle (gzipped)20.76 KB (+0.01% 🔺)
@sentry/browser - Webpack21.98 KB (0%)
@sentry/react - Webpack22.01 KB (0%)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped)28.16 KB (+0.05% 🔺)

@HazATHazAT left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

node 6 tests fails 🤔

@kamilogorek
kamilogorek enabled auto-merge (squash) May 17, 2021 11:45
@onurtemizkan

Copy link
Copy Markdown
ContributorAuthor

Fixed by assigning undefined to global.process instead of deleting it.
Ref: jestjs/jest#5159 (comment)

@AbhiPrasad
AbhiPrasad disabled auto-merge May 19, 2021 14:11
@AbhiPrasad
AbhiPrasad merged commit 1bf5cdd into masterMay 19, 2021
@AbhiPrasad
AbhiPrasad deleted the fix/tracing-avoid-ssr branch May 19, 2021 14:12
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Browser tracing also works in server-side rendering with Node.js V16

4 participants

@onurtemizkan@HazAT@AbhiPrasad@kamilogorek