Skip to content

ref(nextjs): Only import BrowserTracing - #4200

Closed
AbhiPrasad wants to merge 1 commit into
abhi-browser-tracing-exportfrom
abhi-nextjs-browser-tracing
Closed

ref(nextjs): Only import BrowserTracing#4200
AbhiPrasad wants to merge 1 commit into
abhi-browser-tracing-exportfrom
abhi-nextjs-browser-tracing

Conversation

@AbhiPrasad

@AbhiPrasadAbhiPrasad commented Nov 30, 2021

Copy link
Copy Markdown
Contributor

This is dependent on #4199

@github-actions

Copy link
Copy Markdown
Contributor

size-limit report

PathSize
@sentry/browser - CDN Bundle (gzipped)22.49 KB (+0.02% 🔺)
@sentry/browser - Webpack23.37 KB (0%)
@sentry/react - Webpack23.4 KB (0%)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped)29.93 KB (+0.01% 🔺)

@AbhiPrasad

AbhiPrasad commented Dec 1, 2021

Copy link
Copy Markdown
ContributorAuthor

Ok so this doesn't work because the scenario seen in this rollup repl.

Since we spread the imports into an object, they are always included :/

We can only fix this in a breaking change 😢

@AbhiPrasadAbhiPrasad removed this from the Treeshaking / Bundle Size milestone Dec 1, 2021
@AbhiPrasad
AbhiPrasad deleted the abhi-nextjs-browser-tracing branch December 1, 2021 01:59
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@AbhiPrasad