Uh oh!
There was an error while loading. Please reload this page.
ref(browser): Simplify TraceKit parser and reorganize tests - #4514
Conversation
timfish
commented
Feb 8, 2022
Guessing these code analysis results are false positives since it's highlighting regexes that I haven't even modified? |
AbhiPrasad
commented
Feb 9, 2022
It might be that CodeQL only scans code that was changed (and tracekit regex hasn’t been moved for a while). I’ll mark as false positive for now. |
AbhiPrasad
left a comment
There was a problem hiding this comment.
Seems to have ~0.7% difference in minified, non-gzipped bundle (which is what we are focusing on)
@sentry/browser - CDN Bundle (gzipped)
Size limit: 100 KB
Size: 19.63 KB with all dependencies, minified and gzipped
@sentry/browser - CDN Bundle (minified)
Size limit: 120 KB
Size: 62.75 KB with all dependencies and minified
@sentry/browser - Webpack
Size limit: 100 KB
Size: 22.16 KB with all dependencies, minified and gzipped
@sentry/browser - Webpack - gzip = false
Size limit: 100 KB
Size: 75.87 KB with all dependencies and minified
@sentry/react - Webpack
Size limit: 100 KB
Size: 22.19 KB with all dependencies, minified and gzipped
@sentry/nextjs Client - Webpack
Size limit: 100 KB
Size: 46.26 KB with all dependencies, minified and gzipped
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped)
Size limit: 100 KB
Size: 28.18 KB with all dependencies, minified and gzipped
AbhiPrasad
commented
Feb 9, 2022
I'm gonna tag @kamilogorek for a review for some added confidence. |
kamilogorek
left a comment
There was a problem hiding this comment.
LGTM! We have all custom made changes covered with tests, so I trust them just fine.
Refactors and reorganises typekit unit tests:
messageandnamewhich were previously not checkedMakes a few simplifications to tracekit parser including:
argsaddress atstripping to the Chrome regexerror.columnNumbersince it's not used and even the original typekit tests expect what appears in the stack string