Skip to content

chore: add issue forms - #4617

Merged
vladanpaunovic merged 9 commits into
masterfrom
add-issue-forms
Feb 23, 2022
Merged

chore: add issue forms#4617
vladanpaunovic merged 9 commits into
masterfrom
add-issue-forms

Conversation

@vladanpaunovic

@vladanpaunovicvladanpaunovic commented Feb 22, 2022

Copy link
Copy Markdown
Contributor

Add new Github issue forms to this repository

AbhiPrasad
AbhiPrasad approved these changes Feb 22, 2022
View reviewed changes

@AbhiPrasadAbhiPrasad left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

lobsterkatie
lobsterkatie reviewed Feb 22, 2022
View reviewed changes

@lobsterkatielobsterkatie left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some suggestions. Overall I think this could be helpful, though!

Comment thread.github/ISSUE_TEMPLATE/bug.yml Outdated
Comment thread.github/ISSUE_TEMPLATE/bug.yml Outdated
Comment thread.github/ISSUE_TEMPLATE/bug.yml Outdated
Comment thread.github/ISSUE_TEMPLATE/bug.yml
Comment thread.github/ISSUE_TEMPLATE/bug.yml Outdated
Comment thread.github/ISSUE_TEMPLATE/bug.yml
Comment on lines +60 to +83
- type: textarea
id: repro
attributes:
label: Steps to Reproduce
description: How can we see what you're seeing? Specific is terrific.
placeholder: |-
1. What
2. you
3. did.
validations:
required: true
- type: textarea
id: expected
attributes:
label: Expected Result
validations:
required: true
- type: textarea
id: actual
attributes:
label: Actual Result
description: Logs? Screenshots? Yes, please.
validations:
required: true

@lobsterkatielobsterkatieFeb 22, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- type: textarea
id: repro
attributes:
label: Steps to Reproduce
description: How can we see what you're seeing? Specific is terrific.
placeholder: |-
1. What
2. you
3. did.
validations:
required: true
- type: textarea
id: expected
attributes:
label: Expected Result
validations:
required: true
- type: textarea
id: actual
attributes:
label: Actual Result
description: Logs? Screenshots? Yes, please.
validations:
required: true
- type: textarea
id: actual
attributes:
label: Current Behavior
description: Logs? Screenshots? Yes, please.
validations:
required: true
- type: textarea
id: expected
attributes:
label: Expected Behavior
description: What _should_ be happening?
validations:
required: true
- type: textarea
id: repro
attributes:
label: Steps to Reproduce
description: How can we see what you're seeing? Specific is terrific. Repro repos are even better.
placeholder: |-
1. What
2. you
3. did.
validations:
required: true

I switched the order because IMHO the most salient thing is what's actually going wrong.

@vladanpaunovicvladanpaunovicFeb 23, 2022

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Katie.
I would say, all 3 things are important here. It is true that in different scenarios, one is more important than the other. This already follows a known pattern for bug reporting so I would like to keep it as it is.

Comment thread.github/ISSUE_TEMPLATE/config.yml
Comment on lines +1 to +5
blank_issues_enabled: false
contact_links:
- name: Ask a question
url: https://github.com/getsentry/sentry-javascript/discussions
about: Ask questions and discuss with other community members

@lobsterkatielobsterkatieFeb 22, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Steven here, that for the moment it's just easier to have everything be in one place (issues) rather than two (issues and discussions).

Instead I think we should have a template which matches the bug report but has an open-ended "Describe your issue" text box in place of actual/expected/repro.

@vladanpaunovicvladanpaunovicFeb 23, 2022

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool with me. I will point this to issues atm and later make an template with the label question

Comment thread.github/ISSUE_TEMPLATE/feature.yml
label: Problem Statement
description: A clear and concise description of what you want and what your use case is.
placeholder: |-
I want to make whirled peas, but Sentry doesn't blend.

@lobsterkatielobsterkatieFeb 22, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Comment thread.github/ISSUE_TEMPLATE/feature.yml Outdated
vladanpaunovicand others added 4 commits February 23, 2022 09:32
@vladanpaunovic@lobsterkatie
Update .github/ISSUE_TEMPLATE/bug.yml
f704664
Co-authored-by: Katie Byers <lobsterkatie@gmail.com>
@vladanpaunovic@lobsterkatie
Update .github/ISSUE_TEMPLATE/bug.yml
25fd1bb
Co-authored-by: Katie Byers <lobsterkatie@gmail.com>
@vladanpaunovic@lobsterkatie
Update .github/ISSUE_TEMPLATE/bug.yml
6238856
Co-authored-by: Katie Byers <lobsterkatie@gmail.com>
@vladanpaunovic@lobsterkatie
Update .github/ISSUE_TEMPLATE/bug.yml
bb741a9
Co-authored-by: Katie Byers <lobsterkatie@gmail.com>
@github-actions

github-actionsBot commented Feb 23, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report

PathBase Size (0af57a4)Current SizeChange
@sentry/browser - ES5 CDN Bundle (gzipped + minified)19.7 KB19.7 KB-0.01% 🔽
@sentry/browser - ES5 CDN Bundle (minified)63.31 KB63.31 KB0%
@sentry/browser - ES6 CDN Bundle (gzipped + minified)18.37 KB18.37 KB-0.01% 🔽
@sentry/browser - ES6 CDN Bundle (minified)56.48 KB56.48 KB0%
@sentry/browser - Webpack (gzipped + minified)22.16 KB22.16 KB0%
@sentry/browser - Webpack (minified)76.18 KB76.18 KB0%
@sentry/react - Webpack (gzipped + minified)22.19 KB22.19 KB0%
@sentry/nextjs Client - Webpack (gzipped + minified)46.33 KB46.33 KB0%
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified)27.16 KB27.16 KB+0.01% 🔺

vladanpaunovicand others added 3 commits February 23, 2022 09:50
@vladanpaunovic@lobsterkatie
Update .github/ISSUE_TEMPLATE/bug.yml
f19ba9e
Co-authored-by: Katie Byers <lobsterkatie@gmail.com>
@vladanpaunovic
Update config.yml
5f539fe
@vladanpaunovic@lobsterkatie
Update .github/ISSUE_TEMPLATE/feature.yml
188e054
Co-authored-by: Katie Byers <lobsterkatie@gmail.com>
@AbhiPrasad

AbhiPrasad commented Feb 23, 2022

Copy link
Copy Markdown
Contributor

Please rebase this and we can merge!

@vladanpaunovic
vladanpaunovic merged commit e13b087 into masterFeb 23, 2022
@vladanpaunovic
vladanpaunovic deleted the add-issue-forms branch February 23, 2022 13:10
timfish pushed a commit to timfish/sentry-javascript that referenced this pull request Feb 23, 2022
@vladanpaunovic@timfish
chore: add issue forms (getsentry#4617)
b54d7cf
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lobsterkatielobsterkatielobsterkatie left review comments
+1 more reviewer
@AbhiPrasadAbhiPrasadAbhiPrasad approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vladanpaunovic@AbhiPrasad@lobsterkatie