Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 1.8k
fix(angular): Use Angular compiler to compile @sentry/angular#4641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Changes from all commits
383509ba3db0cbfa18a6073876dc69180c4f8c09a02b62152ff0b19a337991fd2aa0122c5bdc978746fb6ce4199824544ee058520447d7fff94bac07824aeab438540cfac7311cb7459File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| /* To learn more about this file see: https://angular.io/guide/workspace-config */ | ||
| { | ||
| "$schema": "../../node_modules/@angular/cli/lib/config/schema.json", | ||
| "version": 1, // version of angular.json | ||
| "projects": { | ||
| "sentry-angular": { | ||
| "projectType": "library", | ||
| "root": ".", | ||
| "sourceRoot": "src", | ||
| "architect": { | ||
| "build": { | ||
| "builder": "@angular-devkit/build-angular:ng-packagr", | ||
| "options": { | ||
| "tsConfig": "tsconfig.ngc.json", | ||
| "project": "ng-package.json" | ||
| }, | ||
| "configurations": { | ||
| "production": { | ||
| "tsConfig": "tsconfig.ngc.json" | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "defaultProject": "sentry-angular" | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| { | ||
| "$schema": "node_modules/ng-packagr/ng-package.schema.json", | ||
| "dest": "build", | ||
| "lib": { | ||
| "entryFile": "src/index.ts", | ||
| "umdModuleIds": { | ||
| "@sentry/browser": "Sentry", | ||
| "@sentry/utils": "Sentry.util" | ||
| } | ||
| }, | ||
| "whitelistedNonPeerDependencies": ["@sentry/browser", "@sentry/utils", "@sentry/types", "tslib"], | ||
| "assets": ["README.md", "LICENSE"] | ||
| } |
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| /* To learn more about this file see: https://angular.io/config/tsconfig. */ | ||
Lms24 marked this conversation as resolved.
Uh oh!There was an error while loading. Please reload this page. | ||
| // This tsconfig is used when building @sentry/angular with the Angular | ||
| // compiler and `ng-packagr`. It configures a production build conforming | ||
| // to the Angular Package Format (APF). | ||
| { | ||
| "extends": "./tsconfig.json", | ||
| "compilerOptions": { | ||
| "target": "es2015", | ||
| "lib": ["dom", "es2015"], | ||
| "baseUrl": "./" | ||
| }, | ||
| "angularCompilerOptions": { | ||
| "skipTemplateCodegen": true, | ||
| "strictMetadataEmit": true, | ||
| "enableResourceInlining": true, | ||
Lms24 marked this conversation as resolved.
Uh oh!There was an error while loading. Please reload this page. | ||
| "strictInjectionParameters": true, | ||
| "strictInputAccessModifiers": true, | ||
| "strictTemplates": true, | ||
| // As per Angular 10, the recommendation from the library creation guide | ||
| // is to disable compilation for the Ivy rendering engine in production builds | ||
| // to ensure compatibility with Angular 10. | ||
| // For Angular 11-13 applications, ngcc and the Angular linker convert the compiled JS | ||
| // at application compile time into an Ivy-compatible version which is then further used in | ||
| // the build process. This ensures compatibility with newer Angular versions than the one | ||
| // that was used to initially compile the library (Angular 10 in our case). | ||
| "enableIvy": false | ||
| } | ||
| } | ||
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.