Skip to content

[v7] feat(core): Delete API class - #4848

Merged
AbhiPrasad merged 2 commits into
7.xfrom
v7-abhi-api-delete
Apr 7, 2022
Merged

[v7] feat(core): Delete API class#4848
AbhiPrasad merged 2 commits into
7.xfrom
v7-abhi-api-delete

Conversation

@AbhiPrasad

@AbhiPrasadAbhiPrasad commented Apr 4, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

Removes the deprecated API class.

See: #4281

Resolves https://getsentry.atlassian.net/browse/WEB-549

@AbhiPrasadAbhiPrasad added this to the 7.0.0 milestone Apr 4, 2022
@github-actions

github-actionsBot commented Apr 4, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
@sentry/browser - ES5 CDN Bundle (gzipped + minified)20.21 KB (0%)
@sentry/browser - ES5 CDN Bundle (minified)65.26 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified)18.89 KB (+0.02% 🔺)
@sentry/browser - ES6 CDN Bundle (minified)58.27 KB (0%)
@sentry/browser - Webpack (gzipped + minified)23.1 KB (-0.55% 🔽)
@sentry/browser - Webpack (minified)81.63 KB (-0.67% 🔽)
@sentry/react - Webpack (gzipped + minified)23.14 KB (-0.55% 🔽)
@sentry/nextjs Client - Webpack (gzipped + minified)47.89 KB (-0.3% 🔽)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified)26.15 KB (0%)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified)24.5 KB (0%)

lforst
lforst approved these changes Apr 5, 2022
View reviewed changes

@lforstlforst left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One test is a bit iffy now but lgtm otherwise

Comment threadpackages/core/test/lib/api.test.ts Outdated
@AbhiPrasad
AbhiPrasad changed the base branch from master to 7.xApril 7, 2022 01:12
@AbhiPrasad
AbhiPrasad marked this pull request as ready for review April 7, 2022 01:12
@AbhiPrasad
AbhiPrasad merged commit 5487dbb into 7.xApr 7, 2022
@AbhiPrasad
AbhiPrasad deleted the v7-abhi-api-delete branch April 7, 2022 01:12
Lms24 pushed a commit that referenced this pull request Apr 7, 2022
@AbhiPrasad@Lms24
[v7] feat(core): Delete API class (#4848)
e277e40
Removes the deprecated `API` class.
Lms24 pushed a commit that referenced this pull request Apr 7, 2022
@AbhiPrasad@Lms24
[v7] feat(core): Delete API class (#4848)
57d37c2
Removes the deprecated `API` class.
lobsterkatie pushed a commit that referenced this pull request Apr 7, 2022
@AbhiPrasad@lobsterkatie
[v7] feat(core): Delete API class (#4848)
7e50a94
Removes the deprecated `API` class.
Lms24 pushed a commit that referenced this pull request Apr 26, 2022
@AbhiPrasad@Lms24
[v7] feat(core): Delete API class (#4848)
d79582d
Removes the deprecated `API` class.
lobsterkatie pushed a commit that referenced this pull request Apr 26, 2022
@AbhiPrasad@lobsterkatie
ref(core): DeleteAPIclass (#4848)
f501391
Removes the deprecated `API` class.
AbhiPrasad added a commit that referenced this pull request May 30, 2022
@AbhiPrasad
ref(core): DeleteAPIclass (#4848)
47fb065
Removes the deprecated `API` class.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@lforstlforstlforst approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@AbhiPrasad@lforst