Uh oh!
There was an error while loading. Please reload this page.
feat(tracing): Add Prisma ORM integration. - #4931
Merged
Merged
Conversation
Contributor
size-limit report 📦
|
vladanpaunovic
commented
Apr 13, 2022
Contributor
@onurtemizkan can you please fix the lint error? |
onurtemizkan
commented
Apr 13, 2022
ContributorAuthor
Disabled the |
onurtemizkanforce-pushed
the
onur/prisma-orm-integration
branch
from
April 14, 2022 16:04
955211b to
fdcad2aCompareonurtemizkanforce-pushed
the
onur/prisma-orm-integration
branch
from
April 19, 2022 10:48
06b41ed to
65e9c8cCompareonurtemizkanforce-pushed
the
onur/prisma-orm-integration
branch
2 times, most recently
from
April 19, 2022 12:54
9f53c2d to
fb6d61fCompareonurtemizkanforce-pushed
the
onur/prisma-orm-integration
branch
from
April 19, 2022 13:35
fb6d61f to
a92f781CompareUh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Abhijeet Prasad <aprasad@sentry.io>
AbhiPrasad
approved these changes
Apr 19, 2022
AbhiPrasad
commented
Apr 19, 2022
Contributor
I think we can merge this in, @onurtemizkan mind also making some docs for this? |
onurtemizkan
commented
Apr 19, 2022
ContributorAuthor
@AbhiPrasad, Sure 👍 |
| NODE_MAJOR=$(node -v | cut -c2- | cut -d. -f1) | ||
| if [ "$NODE_MAJOR" -lt "12" ]; then | ||
| echo "Skipping Prisma tests on Node: $NODE_MAJOR" |
Contributor
There was a problem hiding this comment.
I think going forward we would like everything to be node scripts. Can we convert this to a TS script (we have ts-node in the repo)?
| @@ -0,0 +1,22 @@ | |||
| { | |||
| "name": "sentry-prisma-test", | |||
Contributor
There was a problem hiding this comment.
let's move this out into another PR so we can discuss the integration test separately? In the mean time, we can add sanity check unit tests to this PR (similar to what we have for mongo for ex.)
onurtemizkanforce-pushed
the
onur/prisma-orm-integration
branch
2 times, most recently
from
April 21, 2022 16:17
5258b74 to
575d843CompareAbhiPrasad
approved these changes
Apr 21, 2022
onurtemizkanforce-pushed
the
onur/prisma-orm-integration
branch
from
April 21, 2022 16:19
575d843 to
050d8ddCompareonurtemizkanforce-pushed
the
onur/prisma-orm-integration
branch
from
April 21, 2022 16:57
dc690d0 to
215beafCompareLms24 pushed a commit
that referenced
this pull request
Apr 26, 2022
Co-authored-by: Abhijeet Prasad <aprasad@sentry.io>
lobsterkatie pushed a commit
that referenced
this pull request
Apr 26, 2022
Co-authored-by: Abhijeet Prasad <aprasad@sentry.io>
lobsterkatie pushed a commit
that referenced
this pull request
Apr 26, 2022
Co-authored-by: Abhijeet Prasad <aprasad@sentry.io>
AbhiPrasad added a commit
that referenced
this pull request
May 30, 2022
Co-authored-by: Abhijeet Prasad <aprasad@sentry.io>
Noitidart
commented
Jul 1, 2022
Is it possible to add |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Prisma ORM Tracing Integration.
This implementation is not auto-instrumented, as we seem to need the instance of
PrismaClientsupplied to us.Followed a similar approach with -> #3143 (comment) , using Prisma Client Middleware.
Resolves: #3143