Skip to content

ref(dev): Add dev-utils package - #5038

Closed
lobsterkatie wants to merge 1 commit into
7.xfrom
kmclb-add-dev-utils-package
Closed

ref(dev): Add dev-utils package#5038
lobsterkatie wants to merge 1 commit into
7.xfrom
kmclb-add-dev-utils-package

Conversation

@lobsterkatie

@lobsterkatielobsterkatie commented May 5, 2022

Copy link
Copy Markdown
Member

Since we're not using it immediately, I'm going to wait to merge this until a few other structural changes have gone through. Moving back to draft.


This adds the skeleton of a new dev-utils package, which will eventually hold a lot of the stuff that's started to litter the top level of our repo (rollup helpers, jest transformers, etc), as well as give us a place to put, for example, testing helpers which right now have to be copied across packages.

Work to move things into the package (and update anything that points to the old locations) will happen in follow-up PRs.

Note: There is a little cruft here, of the kind from which all of our packages suffer, which I left alone (for the moment) for simplicity's sake. When we do the work to clean up this junk repo-wide, these crufty areas will get taken care of.

@Lms24Lms24 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's a good change to have this extra package. I left some questions/comments but they shouldn't block for now, given that the package itself is still empty. Seems like building the package fails in CI though. I think if we fix CI, this is good to go from my perspective.

Comment threadpackages/dev-utils/.npmignore Outdated
Comment thread.github/workflows/build.yml Outdated
Comment threadpackages/dev-utils/README.md Outdated
@lobsterkatie
lobsterkatieforce-pushed the kmclb-add-dev-utils-package branch 3 times, most recently from 655d05d to b7e8f57CompareMay 5, 2022 13:52
@github-actions

github-actionsBot commented May 5, 2022

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
@sentry/browser - ES5 CDN Bundle (gzipped + minified)18.78 KB (-6.77% 🔽)
@sentry/browser - ES5 CDN Bundle (minified)58.38 KB (-9.65% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped + minified)17.54 KB (-7% 🔽)
@sentry/browser - ES6 CDN Bundle (minified)52.61 KB (-9.26% 🔽)
@sentry/browser - Webpack (gzipped + minified)19.33 KB (-16.83% 🔽)
@sentry/browser - Webpack (minified)61.47 KB (-24.77% 🔽)
@sentry/react - Webpack (gzipped + minified)19.35 KB (-16.87% 🔽)
@sentry/nextjs Client - Webpack (gzipped + minified)42.81 KB (-10.91% 🔽)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified)24.43 KB (-6.3% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified)23 KB (-6.05% 🔽)

@lobsterkatie
lobsterkatieforce-pushed the kmclb-add-dev-utils-package branch 2 times, most recently from abd939a to 7343ecfCompareMay 5, 2022 16:43
@lobsterkatie
lobsterkatie marked this pull request as draft May 11, 2022 04:36
@lobsterkatie
lobsterkatieforce-pushed the kmclb-add-dev-utils-package branch from 7343ecf to 29e3da8CompareMay 11, 2022 05:32
@lobsterkatie
lobsterkatieforce-pushed the kmclb-add-dev-utils-package branch from 29e3da8 to 5d67d78CompareMay 12, 2022 00:05
@AbhiPrasadAbhiPrasad added this to the 7.0.0 milestone May 12, 2022
@AbhiPrasadAbhiPrasad removed this from the 7.0.0 milestone May 30, 2022
@github-actions

Copy link
Copy Markdown
Contributor

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@AbhiPrasad

Copy link
Copy Markdown
Contributor

This is a great idea we should pursue later on, but for now closing.

@AbhiPrasad
AbhiPrasad deleted the kmclb-add-dev-utils-package branch January 30, 2023 09:52
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@lobsterkatie@AbhiPrasad@Lms24