Uh oh!
There was an error while loading. Please reload this page.
feat(ci): Add Node 18 to test matrix - #5049
Merged
Merged
Conversation
Contributor
size-limit report 📦
|
AbhiPrasadforce-pushed
the
v7-abhi-node-18
branch
6 times, most recently
from
May 17, 2022 21:31
7d4922a to
b605a57CompareAbhiPrasad
requested review from
a team, Lms24 and lforst
and removed request for
a teamMay 17, 2022 22:20
lforst
approved these changes
May 18, 2022
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
timfish
commented
May 19, 2022
Collaborator
My main gripe with fetch on node.js is that you appear to lose proxy/ca options! |
AbhiPrasad added a commit
that referenced
this pull request
May 30, 2022
https://nodejs.org/en/blog/announcements/v18-release-announce/ From reviewing the CHANGELOG (https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V18.md), there seems to be no changes that will affect us in the code. See v17 CHANGELOG: https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V17.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://nodejs.org/en/blog/announcements/v18-release-announce/
From reviewing the CHANGELOG (https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V18.md), there seems to be no changes that will affect us in the code.
See v17 CHANGELOG: https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V17.md
Notable things we can maybe pursue:
Resolves https://getsentry.atlassian.net/browse/WEB-870