Skip to content

fix(tracing): Don't use querySelector when not available - #5160

Merged
lforst merged 1 commit into
7.xfrom
lforst-fix-queryselector-not-available
May 24, 2022
Merged

fix(tracing): Don't use querySelector when not available#5160
lforst merged 1 commit into
7.xfrom
lforst-fix-queryselector-not-available

Conversation

@lforst

Copy link
Copy Markdown
Contributor

Fixes#4098

@lforst
lforst requested review from Lms24 and lobsterkatieMay 24, 2022 12:54
@lforst

Copy link
Copy Markdown
ContributorAuthor

We really need to find a safer type definition for getGlobalObject...

@Lms24Lms24 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@github-actions

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
@sentry/browser - ES5 CDN Bundle (gzipped + minified)19.32 KB (-4.06% 🔽)
@sentry/browser - ES5 CDN Bundle (minified)59.9 KB (-7.3% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped + minified)18.18 KB (-3.63% 🔽)
@sentry/browser - ES6 CDN Bundle (minified)53.58 KB (-7.57% 🔽)
@sentry/browser - Webpack (gzipped + minified)19.87 KB (-14.49% 🔽)
@sentry/browser - Webpack (minified)63.03 KB (-22.87% 🔽)
@sentry/react - Webpack (gzipped + minified)19.89 KB (-14.53% 🔽)
@sentry/nextjs Client - Webpack (gzipped + minified)43.72 KB (-9.03% 🔽)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified)25.34 KB (-2.81% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified)23.9 KB (-2.4% 🔽)

@lforst
lforst merged commit fa5712e into 7.xMay 24, 2022
@lforst
lforst deleted the lforst-fix-queryselector-not-available branch May 24, 2022 13:21
@AbhiPrasadAbhiPrasad added this to the 7.0.0 milestone May 30, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@lforst@Lms24@AbhiPrasad