Uh oh!
There was an error while loading. Please reload this page.
fix(ember): Restore ember package contents - #5318
Conversation
size-limit report 📦
|
Lms24
left a comment
There was a problem hiding this comment.
LGTM. Given how different the ember package is from the rest, I think overriding the default .npmignore is definetily justified.
Just in case you didn't, let's make sure we inspect the created tarball contents before releasing the next patch.
| echo "COMMIT_MESSAGE=$(git log -n 1 --pretty=format:%s $COMMIT_SHA)" >> $GITHUB_ENV | ||
| outputs: | ||
| commit_label: "${{ env.COMMIT_SHA }}: ${{ env.COMMIT_MESSAGE }}" | ||
| commit_label: '${{ env.COMMIT_SHA }}: ${{ env.COMMIT_MESSAGE }}' |
There was a problem hiding this comment.
No action required: I guess those are some automatic Prettier (or similar) changes?
There was a problem hiding this comment.
Yup, I'll leave it (I'm sorry for the messed up git history).
lforst
commented
Jun 27, 2022
I generated all of the tarballs locally before and after the changes in this PR. Diffing the two files only reveals ember changes. |
Problem Description
As reported in #5296, from version
7.1.1to7.2.0of the Ember SDK, a majority of the contents of the npm packages suddenly disappeared.We traced the issue back to a Node.js dependency change (in patch
v16.15.1) that bumped npm from version8.5.5to8.11.0. That npm version bump included a fix (npm/cli#4917 & npm/npm-packlist#102, first appeared in npmv8.11.0) that restores the functionality thatnpm packalso looks at workspace roots for.npmignorefiles. For the ember SDK package, we actually depended on the bug that is now fixed, as a result messing up our package contents.Changes
To fix the ember package contents we simply override the workspace root
.npmignorerules in the.npmignorefile of the ember package. Essentially, for the ember package, this now works as if there were no.npmignorefile in the workspace root.Additionally, as of this PR, we pin the default node version (and implicitly the npm version). So we have reproducible builds.
Fixes#5296