Uh oh!
There was an error while loading. Please reload this page.
ref(tracing): Only add user_id to DSC if sendDefaultPii is true - #5344
Merged
Conversation
Contributor
size-limit report 📦
|
Lms24force-pushed
the
lms-dsc-userid-sendDefaultPii
branch
2 times, most recently
from
July 1, 2022 12:38
37ba42c to
c873b1cCompareuser_id to DSC if sendDefaultPii is trueLms24
marked this pull request as ready for review
July 1, 2022 12:44
revert unintended yarn script deletion
Lms24force-pushed
the
lms-dsc-userid-sendDefaultPii
branch
from
July 1, 2022 12:59
c873b1c to
841e236Comparelforst
approved these changes
Jul 1, 2022
lforst
left a comment
Contributor
There was a problem hiding this comment.
Change-to-test ratio in this PR is just... *chef's kiss* 🤌
Comment on lines
19
to
27
| function createTransactionOnScope(sendDefaultPii: boolean = true) { | ||
| const options = getDefaultNodeClientOptions({ | ||
| dsn: 'https://dogsarebadatkeepingsecrets@squirrelchasers.ingest.sentry.io/12312012', | ||
| tracesSampleRate: 1.0, | ||
| integrations: [new HttpIntegration({ tracing: true })], | ||
| release: '1.0.0', | ||
| environment: 'production', | ||
| sendDefaultPii, | ||
| }); |
Contributor
There was a problem hiding this comment.
(optional) We could refactor this a bit so that createTransactionOnScope takes node client options as an argument which override a default (default being what's there now).
MemberAuthor
There was a problem hiding this comment.
Yes, good idea; that seems like a more sustainable solution
| it('does not add the user_id to the baggage header if sendDefaultPii is set to false', async () => { | ||
| nock('http://dogs.are.great').get('/').reply(200); | ||
| createTransactionOnScope(false); |
Contributor
There was a problem hiding this comment.
Just seeing this in tests is so glorius. Sentry.startTransaction() should really just instantly put a transaction on the scope... I hope we get to that some day.
takes now an options argument instead of just the sendDefaultPii flag
lforst
approved these changes
Jul 4, 2022
lforst
left a comment
Contributor
There was a problem hiding this comment.
Thanks for adding my suggestion :D
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the check if
sendDefaultPiiis set totruebefore adding theuser_idwhen populating DSC.Additionally, the PR adds some tests to check for the changed behaviour.
resolves#5343