fix(browser): update Request checks to be valid in Deno by GJZwiers · Pull Request #5630 · getsentry/sentry-javascript

GJZwiers · 2022-08-24T19:35:32Z

In Deno @sentry/browser is almost usable, but the check new Request('') fails silently because Deno throws a TypeError: invalid URL that goes to a catch block. This changes the Request call to include a valid URL http://www.example.com so that @sentry/browser can be imported in Deno without this issue.

AbhiPrasad · 2022-08-24T19:49:38Z

Hey @GJZwiers, thanks for the contribution! How are you using Sentry with deno?

GJZwiers · 2022-08-24T20:07:45Z

Hey @GJZwiers, thanks for the contribution! How are you using Sentry with deno?

Hello! Recently I tried to port the browser package to Deno, which works well enough for sending events to Sentry (but it's difficult to maintain for me). A lot of Deno users also use CDNs to import code, for example there is another Sentry port in the making. But in the next release of Deno there will be more support for importing npm packages, which will look something like this:

import*asSentryfrom'npm:@sentry/browser';

I believe most of the browser APIs used in sentry are now also supported in Deno, so I think it should be possible, maybe with a few small tweaks, to use Sentry in Deno this way.

AbhiPrasad

Awesome, this sounds reasonable to me, cc @timfish

timfish · 2022-08-29T21:35:55Z

I've just had a chance to try out the Deno support for npm packages. It looks like npm packages support currently requires the --unstable flag so the behaviour is likely to improve/change over time.

Whereas @sentry/browser might be usable at some point, there are still outstanding issues:

Merely referencing process in @sentry/utils causes some node shims to be automatically imported which then prompt for access to the NODE_DEBUG environment variable. There's currently no way to prevent this
If I enable debug: true I get Uncaught TypeError: Cannot read properties of undefined (reading 'log') from @sentry/utils logger/consoleSandbox
I haven't managed to get the npm browser package to send events to Sentry from Deno yet

There are also some other key features which I suspect will always need to be specifically coded for Deno:

Support for sending unhandled error events due to the aggressive way Deno closes the process. The only way I've got these to send reliably is to call event.preventDefault()and then rethrow the error after flushing is complete
Stack trace file path normalisation which can be particularly tricky due to Denos default of no filesystem access
Deno specific context

As Deno requires a valid URL when calling `new Request`, `example.com` was used but this caused problems. This PR changes it to a data URL as it does not rely on external dependencies and is a valid URL in Deno. Fixes: #18218 Previous PR for that: #5630

GJZwiers · 2022-08-24T19:35:32Z

In Deno @sentry/browser is almost usable, but the check new Request('') fails silently because Deno throws a TypeError: invalid URL that goes to a catch block. This changes the Request call to include a valid URL http://www.example.com so that @sentry/browser can be imported in Deno without this issue.

AbhiPrasad · 2022-08-24T19:49:38Z

Hey @GJZwiers, thanks for the contribution! How are you using Sentry with deno?

GJZwiers · 2022-08-24T20:07:45Z

Hey @GJZwiers, thanks for the contribution! How are you using Sentry with deno?

Hello! Recently I tried to port the browser package to Deno, which works well enough for sending events to Sentry (but it's difficult to maintain for me). A lot of Deno users also use CDNs to import code, for example there is another Sentry port in the making. But in the next release of Deno there will be more support for importing npm packages, which will look something like this:

import*asSentryfrom'npm:@sentry/browser';

I believe most of the browser APIs used in sentry are now also supported in Deno, so I think it should be possible, maybe with a few small tweaks, to use Sentry in Deno this way.

AbhiPrasad

Awesome, this sounds reasonable to me, cc @timfish

timfish · 2022-08-29T21:35:55Z

I've just had a chance to try out the Deno support for npm packages. It looks like npm packages support currently requires the --unstable flag so the behaviour is likely to improve/change over time.

Whereas @sentry/browser might be usable at some point, there are still outstanding issues:

Merely referencing process in @sentry/utils causes some node shims to be automatically imported which then prompt for access to the NODE_DEBUG environment variable. There's currently no way to prevent this
If I enable debug: true I get Uncaught TypeError: Cannot read properties of undefined (reading 'log') from @sentry/utils logger/consoleSandbox
I haven't managed to get the npm browser package to send events to Sentry from Deno yet

There are also some other key features which I suspect will always need to be specifically coded for Deno:

Support for sending unhandled error events due to the aggressive way Deno closes the process. The only way I've got these to send reliably is to call event.preventDefault()and then rethrow the error after flushing is complete
Stack trace file path normalisation which can be particularly tricky due to Denos default of no filesystem access
Deno specific context

As Deno requires a valid URL when calling `new Request`, `example.com` was used but this caused problems. This PR changes it to a data URL as it does not rely on external dependencies and is a valid URL in Deno. Fixes: #18218 Previous PR for that: #5630

GJZwiers · 2022-08-24T19:35:32Z

In Deno @sentry/browser is almost usable, but the check new Request('') fails silently because Deno throws a TypeError: invalid URL that goes to a catch block. This changes the Request call to include a valid URL http://www.example.com so that @sentry/browser can be imported in Deno without this issue.

AbhiPrasad · 2022-08-24T19:49:38Z

Hey @GJZwiers, thanks for the contribution! How are you using Sentry with deno?

GJZwiers · 2022-08-24T20:07:45Z

Hey @GJZwiers, thanks for the contribution! How are you using Sentry with deno?

Hello! Recently I tried to port the browser package to Deno, which works well enough for sending events to Sentry (but it's difficult to maintain for me). A lot of Deno users also use CDNs to import code, for example there is another Sentry port in the making. But in the next release of Deno there will be more support for importing npm packages, which will look something like this:

import*asSentryfrom'npm:@sentry/browser';

I believe most of the browser APIs used in sentry are now also supported in Deno, so I think it should be possible, maybe with a few small tweaks, to use Sentry in Deno this way.

AbhiPrasad

Awesome, this sounds reasonable to me, cc @timfish

timfish · 2022-08-29T21:35:55Z

I've just had a chance to try out the Deno support for npm packages. It looks like npm packages support currently requires the --unstable flag so the behaviour is likely to improve/change over time.

Whereas @sentry/browser might be usable at some point, there are still outstanding issues:

Merely referencing process in @sentry/utils causes some node shims to be automatically imported which then prompt for access to the NODE_DEBUG environment variable. There's currently no way to prevent this
If I enable debug: true I get Uncaught TypeError: Cannot read properties of undefined (reading 'log') from @sentry/utils logger/consoleSandbox
I haven't managed to get the npm browser package to send events to Sentry from Deno yet

There are also some other key features which I suspect will always need to be specifically coded for Deno:

Support for sending unhandled error events due to the aggressive way Deno closes the process. The only way I've got these to send reliably is to call event.preventDefault()and then rethrow the error after flushing is complete
Stack trace file path normalisation which can be particularly tricky due to Denos default of no filesystem access
Deno specific context

As Deno requires a valid URL when calling `new Request`, `example.com` was used but this caused problems. This PR changes it to a data URL as it does not rely on external dependencies and is a valid URL in Deno. Fixes: #18218 Previous PR for that: #5630

GJZwiers · 2022-08-24T19:35:32Z

In Deno @sentry/browser is almost usable, but the check new Request('') fails silently because Deno throws a TypeError: invalid URL that goes to a catch block. This changes the Request call to include a valid URL http://www.example.com so that @sentry/browser can be imported in Deno without this issue.

AbhiPrasad · 2022-08-24T19:49:38Z

Hey @GJZwiers, thanks for the contribution! How are you using Sentry with deno?

GJZwiers · 2022-08-24T20:07:45Z

Hey @GJZwiers, thanks for the contribution! How are you using Sentry with deno?

Hello! Recently I tried to port the browser package to Deno, which works well enough for sending events to Sentry (but it's difficult to maintain for me). A lot of Deno users also use CDNs to import code, for example there is another Sentry port in the making. But in the next release of Deno there will be more support for importing npm packages, which will look something like this:

import*asSentryfrom'npm:@sentry/browser';

I believe most of the browser APIs used in sentry are now also supported in Deno, so I think it should be possible, maybe with a few small tweaks, to use Sentry in Deno this way.

AbhiPrasad

Awesome, this sounds reasonable to me, cc @timfish

timfish · 2022-08-29T21:35:55Z

I've just had a chance to try out the Deno support for npm packages. It looks like npm packages support currently requires the --unstable flag so the behaviour is likely to improve/change over time.

Whereas @sentry/browser might be usable at some point, there are still outstanding issues:

Merely referencing process in @sentry/utils causes some node shims to be automatically imported which then prompt for access to the NODE_DEBUG environment variable. There's currently no way to prevent this
If I enable debug: true I get Uncaught TypeError: Cannot read properties of undefined (reading 'log') from @sentry/utils logger/consoleSandbox
I haven't managed to get the npm browser package to send events to Sentry from Deno yet

There are also some other key features which I suspect will always need to be specifically coded for Deno:

Support for sending unhandled error events due to the aggressive way Deno closes the process. The only way I've got these to send reliably is to call event.preventDefault()and then rethrow the error after flushing is complete
Stack trace file path normalisation which can be particularly tricky due to Denos default of no filesystem access
Deno specific context

As Deno requires a valid URL when calling `new Request`, `example.com` was used but this caused problems. This PR changes it to a data URL as it does not rely on external dependencies and is a valid URL in Deno. Fixes: #18218 Previous PR for that: #5630

GJZwiers · 2022-08-24T19:35:32Z

In Deno @sentry/browser is almost usable, but the check new Request('') fails silently because Deno throws a TypeError: invalid URL that goes to a catch block. This changes the Request call to include a valid URL http://www.example.com so that @sentry/browser can be imported in Deno without this issue.

AbhiPrasad · 2022-08-24T19:49:38Z

Hey @GJZwiers, thanks for the contribution! How are you using Sentry with deno?

GJZwiers · 2022-08-24T20:07:45Z

Hey @GJZwiers, thanks for the contribution! How are you using Sentry with deno?

Hello! Recently I tried to port the browser package to Deno, which works well enough for sending events to Sentry (but it's difficult to maintain for me). A lot of Deno users also use CDNs to import code, for example there is another Sentry port in the making. But in the next release of Deno there will be more support for importing npm packages, which will look something like this:

import*asSentryfrom'npm:@sentry/browser';

I believe most of the browser APIs used in sentry are now also supported in Deno, so I think it should be possible, maybe with a few small tweaks, to use Sentry in Deno this way.

AbhiPrasad

Awesome, this sounds reasonable to me, cc @timfish

timfish · 2022-08-29T21:35:55Z

I've just had a chance to try out the Deno support for npm packages. It looks like npm packages support currently requires the --unstable flag so the behaviour is likely to improve/change over time.

Whereas @sentry/browser might be usable at some point, there are still outstanding issues:

Merely referencing process in @sentry/utils causes some node shims to be automatically imported which then prompt for access to the NODE_DEBUG environment variable. There's currently no way to prevent this
If I enable debug: true I get Uncaught TypeError: Cannot read properties of undefined (reading 'log') from @sentry/utils logger/consoleSandbox
I haven't managed to get the npm browser package to send events to Sentry from Deno yet

There are also some other key features which I suspect will always need to be specifically coded for Deno:

Support for sending unhandled error events due to the aggressive way Deno closes the process. The only way I've got these to send reliably is to call event.preventDefault()and then rethrow the error after flushing is complete
Stack trace file path normalisation which can be particularly tricky due to Denos default of no filesystem access
Deno specific context

As Deno requires a valid URL when calling `new Request`, `example.com` was used but this caused problems. This PR changes it to a data URL as it does not rely on external dependencies and is a valid URL in Deno. Fixes: #18218 Previous PR for that: #5630

GJZwiers · 2022-08-24T19:35:32Z

In Deno @sentry/browser is almost usable, but the check new Request('') fails silently because Deno throws a TypeError: invalid URL that goes to a catch block. This changes the Request call to include a valid URL http://www.example.com so that @sentry/browser can be imported in Deno without this issue.

AbhiPrasad · 2022-08-24T19:49:38Z

Hey @GJZwiers, thanks for the contribution! How are you using Sentry with deno?

GJZwiers · 2022-08-24T20:07:45Z

Hey @GJZwiers, thanks for the contribution! How are you using Sentry with deno?

Hello! Recently I tried to port the browser package to Deno, which works well enough for sending events to Sentry (but it's difficult to maintain for me). A lot of Deno users also use CDNs to import code, for example there is another Sentry port in the making. But in the next release of Deno there will be more support for importing npm packages, which will look something like this:

import*asSentryfrom'npm:@sentry/browser';

I believe most of the browser APIs used in sentry are now also supported in Deno, so I think it should be possible, maybe with a few small tweaks, to use Sentry in Deno this way.

AbhiPrasad

Awesome, this sounds reasonable to me, cc @timfish

timfish · 2022-08-29T21:35:55Z

I've just had a chance to try out the Deno support for npm packages. It looks like npm packages support currently requires the --unstable flag so the behaviour is likely to improve/change over time.

Whereas @sentry/browser might be usable at some point, there are still outstanding issues:

Merely referencing process in @sentry/utils causes some node shims to be automatically imported which then prompt for access to the NODE_DEBUG environment variable. There's currently no way to prevent this
If I enable debug: true I get Uncaught TypeError: Cannot read properties of undefined (reading 'log') from @sentry/utils logger/consoleSandbox
I haven't managed to get the npm browser package to send events to Sentry from Deno yet

There are also some other key features which I suspect will always need to be specifically coded for Deno:

Support for sending unhandled error events due to the aggressive way Deno closes the process. The only way I've got these to send reliably is to call event.preventDefault()and then rethrow the error after flushing is complete
Stack trace file path normalisation which can be particularly tricky due to Denos default of no filesystem access
Deno specific context

As Deno requires a valid URL when calling `new Request`, `example.com` was used but this caused problems. This PR changes it to a data URL as it does not rely on external dependencies and is a valid URL in Deno. Fixes: #18218 Previous PR for that: #5630

GJZwiers · 2022-08-24T19:35:32Z

In Deno @sentry/browser is almost usable, but the check new Request('') fails silently because Deno throws a TypeError: invalid URL that goes to a catch block. This changes the Request call to include a valid URL http://www.example.com so that @sentry/browser can be imported in Deno without this issue.

AbhiPrasad · 2022-08-24T19:49:38Z

Hey @GJZwiers, thanks for the contribution! How are you using Sentry with deno?

GJZwiers · 2022-08-24T20:07:45Z

Hey @GJZwiers, thanks for the contribution! How are you using Sentry with deno?

Hello! Recently I tried to port the browser package to Deno, which works well enough for sending events to Sentry (but it's difficult to maintain for me). A lot of Deno users also use CDNs to import code, for example there is another Sentry port in the making. But in the next release of Deno there will be more support for importing npm packages, which will look something like this:

import*asSentryfrom'npm:@sentry/browser';

I believe most of the browser APIs used in sentry are now also supported in Deno, so I think it should be possible, maybe with a few small tweaks, to use Sentry in Deno this way.

AbhiPrasad

Awesome, this sounds reasonable to me, cc @timfish

timfish · 2022-08-29T21:35:55Z

I've just had a chance to try out the Deno support for npm packages. It looks like npm packages support currently requires the --unstable flag so the behaviour is likely to improve/change over time.

Whereas @sentry/browser might be usable at some point, there are still outstanding issues:

Merely referencing process in @sentry/utils causes some node shims to be automatically imported which then prompt for access to the NODE_DEBUG environment variable. There's currently no way to prevent this
If I enable debug: true I get Uncaught TypeError: Cannot read properties of undefined (reading 'log') from @sentry/utils logger/consoleSandbox
I haven't managed to get the npm browser package to send events to Sentry from Deno yet

There are also some other key features which I suspect will always need to be specifically coded for Deno:

Support for sending unhandled error events due to the aggressive way Deno closes the process. The only way I've got these to send reliably is to call event.preventDefault()and then rethrow the error after flushing is complete
Stack trace file path normalisation which can be particularly tricky due to Denos default of no filesystem access
Deno specific context

As Deno requires a valid URL when calling `new Request`, `example.com` was used but this caused problems. This PR changes it to a data URL as it does not rely on external dependencies and is a valid URL in Deno. Fixes: #18218 Previous PR for that: #5630

GJZwiers · 2022-08-24T19:35:32Z

In Deno @sentry/browser is almost usable, but the check new Request('') fails silently because Deno throws a TypeError: invalid URL that goes to a catch block. This changes the Request call to include a valid URL http://www.example.com so that @sentry/browser can be imported in Deno without this issue.

AbhiPrasad · 2022-08-24T19:49:38Z

Hey @GJZwiers, thanks for the contribution! How are you using Sentry with deno?

GJZwiers · 2022-08-24T20:07:45Z

Hey @GJZwiers, thanks for the contribution! How are you using Sentry with deno?

Hello! Recently I tried to port the browser package to Deno, which works well enough for sending events to Sentry (but it's difficult to maintain for me). A lot of Deno users also use CDNs to import code, for example there is another Sentry port in the making. But in the next release of Deno there will be more support for importing npm packages, which will look something like this:

import*asSentryfrom'npm:@sentry/browser';

I believe most of the browser APIs used in sentry are now also supported in Deno, so I think it should be possible, maybe with a few small tweaks, to use Sentry in Deno this way.

AbhiPrasad

Awesome, this sounds reasonable to me, cc @timfish

timfish · 2022-08-29T21:35:55Z

I've just had a chance to try out the Deno support for npm packages. It looks like npm packages support currently requires the --unstable flag so the behaviour is likely to improve/change over time.

Whereas @sentry/browser might be usable at some point, there are still outstanding issues:

Merely referencing process in @sentry/utils causes some node shims to be automatically imported which then prompt for access to the NODE_DEBUG environment variable. There's currently no way to prevent this
If I enable debug: true I get Uncaught TypeError: Cannot read properties of undefined (reading 'log') from @sentry/utils logger/consoleSandbox
I haven't managed to get the npm browser package to send events to Sentry from Deno yet

There are also some other key features which I suspect will always need to be specifically coded for Deno:

Support for sending unhandled error events due to the aggressive way Deno closes the process. The only way I've got these to send reliably is to call event.preventDefault()and then rethrow the error after flushing is complete
Stack trace file path normalisation which can be particularly tricky due to Denos default of no filesystem access
Deno specific context

As Deno requires a valid URL when calling `new Request`, `example.com` was used but this caused problems. This PR changes it to a data URL as it does not rely on external dependencies and is a valid URL in Deno. Fixes: #18218 Previous PR for that: #5630

fix(browser): use valid urls in Request checks
dd71113

AbhiPrasad approved these changes Aug 29, 2022
View reviewed changes

AbhiPrasad merged commit 14a7a45 into getsentry:masterAug 29, 2022

GJZwiers deleted the update_request_check branch August 29, 2022 20:07