Uh oh!
There was an error while loading. Please reload this page.
fix(node): contexts cannot be overridden and culture never included - #5677
Merged
Conversation
contexts cannot be overridden and culture never includedAbhiPrasad
approved these changes
Sep 1, 2022
AbhiPrasad
left a comment
Contributor
There was a problem hiding this comment.
Yeah - let's get this out with a patch release considering theres some TS issues that need to be released as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@AbhiPrasad sure was right about #5512 needing some integration tests!
I will do a PR to add integration tests but for now, this PR fixes two issues:
typeofwhich stops the node culture detection from working entirely