Uh oh!
There was an error while loading. Please reload this page.
draft: Add metadata around transaction name changes - #5709
Conversation
size-limit report 📦
|
5c28e06 to
8c00b71Compare| nameChanges: TransactionNameChange[]; | ||
| /** The total number of propagations that happened */ | ||
| numPropagations: number; |
There was a problem hiding this comment.
This is called propagations on TransactionNameChange, would opt for using the same shorter name here:
| numPropagations: number; | |
| propagations: number; |
| */ | ||
| export interface TransactionNameChange { | ||
| // new name | ||
| name: string; |
There was a problem hiding this comment.
As discussed offline, we don't require the name for analysis right now. If we drop it, we further prevent the possibility of capturing unintended.
| // new name | ||
| name: string; | ||
| // unix timestamp when the name was changed | ||
| timestamp: number; |
There was a problem hiding this comment.
FTR: The develop spec and Relay protocol definition should use the same type as other timestamps in the protocol, allowing for ISO strings in addition to numbers.
AbhiPrasad
commented
Sep 8, 2022
Alright - I'm going to split this PR up so we can start reviewing/testing/and merging in components we can ship |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
This is a draft PR that adds metadata around transaction name changes for #5679. It's mainly being used to get feedback around the data being sent, and the general approach being used.
If folks are fine with this, I'll split this up into smaller PRs with test changes.
The schema looks like this:
In addition to an array of these transaction name changes, we also store the total amount of propagations, which should help understand the relative nature of the propagations.