Skip to content

fix(nextjs): Rename nextjs.data.server ops - #5830

Merged
AbhiPrasad merged 2 commits into
masterfrom
abhi-nextjs-data-fetcher
Sep 28, 2022
Merged

fix(nextjs): Rename nextjs.data.server ops#5830
AbhiPrasad merged 2 commits into
masterfrom
abhi-nextjs-data-fetcher

Conversation

@AbhiPrasad

@AbhiPrasadAbhiPrasad commented Sep 27, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

As per the span operation audit, this transaction is a http request processed on the server, so we should rename the span op.

https://www.notion.so/sentry/Set-up-an-audit-for-SDK-consistency-for-span-operations-to-enable-performance-issues-addf02a8fa234dda8acf48d4ff9b8efb?d=b852bdd1e9914d2ca74c1052296081f3#d04af01302604881999b1bd29c837b1f

ref: #5837

nextjs.data.server -> http.server for transactions, and nextjs.data.server -> function.nextjs for spans.

@AbhiPrasad
AbhiPrasadforce-pushed the abhi-nextjs-data-fetcher branch from 5497517 to c7db147CompareSeptember 27, 2022 11:50
@AbhiPrasadAbhiPrasad mentioned this pull request Sep 27, 2022
Closed
6 tasks
@lforst

lforst commented Sep 27, 2022

Copy link
Copy Markdown
Contributor

Tests fail

@AbhiPrasadAbhiPrasad changed the title fix(nextjs): Rename data fetch span op to http.serverfix(nextjs): Rename nextjs.data.server opsSep 27, 2022
@AbhiPrasadAbhiPrasad mentioned this pull request Sep 27, 2022
Closed
@AbhiPrasad
AbhiPrasad merged commit fac1103 into masterSep 28, 2022
@AbhiPrasad
AbhiPrasad deleted the abhi-nextjs-data-fetcher branch September 28, 2022 09:14
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@lforstlforstlforst approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AbhiPrasad@lforst