Uh oh!
There was an error while loading. Please reload this page.
fix(ember): align span operations to new operations - #5883
Conversation
| 'ui.ember.route.setup_controller | slow-loading-route.index', | ||
| 'ui.ember.runloop.routerTransitions | undefined', | ||
| 'ui.ember.component.render | component:link-to', | ||
| 'ui.ember.component.render | component:link-to', |
There was a problem hiding this comment.
Should I change ember.route.model operation in this file?
There was a problem hiding this comment.
Yes we should change that to prepend ui
AbhiPrasad
commented
Oct 5, 2022
Hey @outsideris thanks for opening a PR! Could you split this up so that you create a PR for each package (one PR for ember, one PR for serverless, etc.)? I know that’s a little more work, but it’ll make it easier to review changes (plus it’ll be more contributions for you 😄) |
outsideris
commented
Oct 5, 2022
Sure, I will split them. |
outsideris
commented
Oct 5, 2022
I updated this PR for only |
Signed-off-by: Outsider <outsideris@gmail.com>
AbhiPrasad
left a comment
There was a problem hiding this comment.
Thanks for splitting everything up!
Ref: #5837
As the description, I changed span operations to new operations. Is it right?
My local development environment is not the same as CI environments, so I will fix some broken lint or tests after I can see CI results.