Uh oh!
There was an error while loading. Please reload this page.
fix(utils): Rename global.ts -> worldwide.ts - #5969
Merged
Merged
Conversation
AbhiPrasad
requested review from
a team, lforst and lobsterkatie
and removed request for
a teamOctober 17, 2022 09:42
Contributor
size-limit report 📦
|
AbhiPrasad
commented
Oct 17, 2022
ContributorAuthor
Sizebot 🤔 |
Lms24
approved these changes
Oct 17, 2022
Lms24
left a comment
Member
There was a problem hiding this comment.
Lol why not :D
Probably one of the funniest fixes I've seen lately but if it works...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes#5894
fixes#5773
Renames
global.tstoworldwide.tsso we don't have issues with bundlers like as is described in https://docs.sentry.io/platforms/javascript/troubleshooting/#build-errors-with-vite.Luckily the rest of our references to global is removed since we did changes with #5611.
It's not quite our responsibility to handle this, since Vite themselves recommends not use variables like global with the define setting, but we can unblock folks from not having build errors with our SDK, so I'm fine with this change. Opinions are welcome.