Uh oh!
There was an error while loading. Please reload this page.
feat(remix): Enable RequestData integration for server-side requests - #6007
Merged
Conversation
lobsterkatieforce-pushed
the
kmclb-remix-enable-RequestData-integration
branch
from
October 21, 2022 06:14
ac13c62 to
bc9c930Comparelobsterkatie
commented
Oct 21, 2022
MemberAuthor
@onurtemizkan - Currently some of the tests are failing here, consistently timing out, for reasons I've been trying debug all evening but have come up empty on. Mind taking a look? |
20 tasks
onurtemizkan
commented
Oct 24, 2022
Contributor
@lobsterkatie, sure I'm checking now 👍 |
lobsterkatieforce-pushed
the
kmclb-remix-enable-RequestData-integration
branch
from
October 27, 2022 06:58
bc9c930 to
b08642eComparelobsterkatie
commented
Oct 27, 2022
MemberAuthor
@onurtemizkan - Your fixes worked! Thanks! |
lobsterkatie
marked this pull request as ready for review
October 27, 2022 07:29
AbhiPrasad
approved these changes
Oct 27, 2022
AbhiPrasad
commented
Oct 27, 2022
Contributor
Gonna merge this in for the release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables the new
RequestDataintegration in the remix SDK in order to add request data to server-side events. The integration itself is already installed automatically when the SDK initializes, because it's one of the underlying node SDK's default integrations, but without access to the request, it currently no-ops. This enables it to function as intended by storing the request object in the scope'ssdkProcessingMetadata.