Skip to content

feat(otel): Add inject functionality to SentryPropagator - #6114

Merged
AbhiPrasad merged 2 commits into
masterfrom
abhi-otel-propagator-inject
Nov 2, 2022
Merged

feat(otel): Add inject functionality to SentryPropagator#6114
AbhiPrasad merged 2 commits into
masterfrom
abhi-otel-propagator-inject

Conversation

@AbhiPrasad

@AbhiPrasadAbhiPrasad commented Nov 2, 2022

Copy link
Copy Markdown
Contributor

ref #6107

Inject sentry-trace and baggage headers into context so it's gets propagated on outgoing requests. Very similar to approach taken with https://github.com/open-telemetry/opentelemetry-js/blob/main/packages/opentelemetry-propagator-b3/src/B3SinglePropagator.ts

@AbhiPrasad
AbhiPrasad requested a review from mydeaNovember 2, 2022 11:45
@AbhiPrasadAbhiPrasad added this to the OpenTelemetry Support milestone Nov 2, 2022
@AbhiPrasadAbhiPrasad self-assigned this Nov 2, 2022
@AbhiPrasad
AbhiPrasadforce-pushed the abhi-otel-propagator-inject branch from b5674f9 to 7bba4d2CompareNovember 2, 2022 12:46
@AbhiPrasadAbhiPrasad mentioned this pull request Nov 2, 2022
5 tasks
@github-actions

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
@sentry/browser - ES5 CDN Bundle (gzipped + minified)19.5 KB (+0.02% 🔺)
@sentry/browser - ES5 CDN Bundle (minified)60.35 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified)18.13 KB (+0.01% 🔺)
@sentry/browser - ES6 CDN Bundle (minified)53.68 KB (0%)
@sentry/browser - Webpack (gzipped + minified)19.87 KB (0%)
@sentry/browser - Webpack (minified)65.09 KB (0%)
@sentry/react - Webpack (gzipped + minified)19.89 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified)45.79 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified)26.25 KB (+0.01% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified)24.63 KB (+0.01% 🔺)

});

describe('SentryPropagator', () => {
const propogator = new SentryPropagator();

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is still a propogator leftover ;)

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dang it!!!

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed with bff9421

@AbhiPrasad
AbhiPrasad enabled auto-merge (squash) November 2, 2022 15:24
@AbhiPrasad
AbhiPrasad merged commit f36c268 into masterNov 2, 2022
@AbhiPrasad
AbhiPrasad deleted the abhi-otel-propagator-inject branch November 2, 2022 15:27
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@AbhiPrasad@mydea