Uh oh!
There was an error while loading. Please reload this page.
feat(core): Add instrumenter option to ClientOptions - #6128
Merged
Conversation
4 tasks
mydea
commented
Nov 3, 2022
Uh oh!
There was an error while loading. Please reload this page.
instrumentor option to Node SDKinstrumenter option to Node SDKmydeaforce-pushed
the
fn/otel-instrumenter
branch
from
November 3, 2022 15:45
52a9a7f to
f05cdebCompareinstrumenter option to Node SDKinstrumenter option to ClientOptionsinstrumenter option to ClientOptionsinstrumenter option to ClientOptionsAbhiPrasad
approved these changes
Nov 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new option
instrumenterto the the client options, which can besentryoroteland defaults tootel.Nothing is done with that option yet, this will happen in follow up PRs.
It will only have an effect when being set in the node SDK.
ref #6127