Uh oh!
There was an error while loading. Please reload this page.
chore(replay): Align and clean up tsconfig.jsons - #6308
Merged
Conversation
Contributor
size-limit report 📦
|
tsconfig.jsonstsconfig.jsonsLms24force-pushed
the
lms-replay-build-tsconfigs
branch
from
November 25, 2022 15:19
626244b to
be5f26eCompare
This was referenced Nov 25, 2022
mydeaforce-pushed
the
lms-replay-build-tsconfigs
branch
from
November 28, 2022 08:21
bc912c4 to
827d0ecCompareLms24force-pushed
the
lms-replay-build-tsconfigs
branch
from
November 29, 2022 14:35
bf5ff2e to
9846e4cCompareLms24force-pushed
the
lms-replay-build-tsconfigs
branch
from
November 29, 2022 15:12
6114aac to
fb6816eComparetest more test remove duplicated `globals` entry in jest.config after rebase add `__DEBUG_BUILD__`
Lms24force-pushed
the
lms-replay-build-tsconfigs
branch
from
November 29, 2022 15:51
fb6816e to
12a90b6CompareLms24
marked this pull request as ready for review
November 29, 2022 16:12
mydea
reviewed
Nov 29, 2022
| "resolveJsonModule": true, | ||
| "skipLibCheck": true, | ||
| "target": "es5" | ||
| "target": "es5", |
Member
There was a problem hiding this comment.
l: Is it on purpose that we keep es5 as target here? Just making sure :D
MemberAuthor
There was a problem hiding this comment.
Good point, we should probably change it to ES6
Lms24
commented
Nov 29, 2022
MemberAuthor
Well, just took me a day to fight tests 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aligns and cleans up the
tsconfig.jsonfiles in the replay package. In preparations to applying the monorepo's rollup and sucrase configs, we should first align the tsconfigs. This PR:tsconfig.core.jsonandtsconfig.worker.json. For now we can first focus on the core build and later on revisit the worker build config.tsconfig.test.json)ref: #6280