Skip to content

ref(replay): Improve isBrowser check - #6328

Merged
mydea merged 1 commit into
masterfrom
fn/replay-is-browser
Nov 29, 2022
Merged

ref(replay): Improve isBrowser check#6328
mydea merged 1 commit into
masterfrom
fn/replay-is-browser

Conversation

@mydea

Copy link
Copy Markdown
Member

Extracted out of #6316, as these are only semi-related. This should allow us to better evaluate bundle size changes due to WINDOW

For now, just changed the logic a bit to use isNodeEnv under the hood. In a next step we should evaluate if we can remove some of these checks.

@mydea
mydea requested a review from Lms24November 29, 2022 12:09
@mydeamydea self-assigned this Nov 29, 2022
@github-actions

github-actionsBot commented Nov 29, 2022

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
@sentry/browser - ES5 CDN Bundle (gzipped + minified)19.54 KB (+0.01% 🔺)
@sentry/browser - ES5 CDN Bundle (minified)60.42 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified)18.21 KB (+0.03% 🔺)
@sentry/browser - ES6 CDN Bundle (minified)53.76 KB (0%)
@sentry/browser - Webpack (gzipped + minified)19.94 KB (0%)
@sentry/browser - Webpack (minified)65.25 KB (0%)
@sentry/react - Webpack (gzipped + minified)19.96 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified)45.96 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified)26.41 KB (0%)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified)24.83 KB (+0.01% 🔺)
@sentry/replay index.js63.38 KB (+0.03% 🔺)
@sentry/replay - Webpack (gzipped + minified)63.39 KB (+0.03% 🔺)
@sentry/replay - Webpack (minified)204.81 KB (+0.01% 🔺)

@mydea
mydeaforce-pushed the fn/replay-is-browser branch from a1a721b to 0bd1527CompareNovember 29, 2022 14:13
@mydea
mydea merged commit 1ae2726 into masterNov 29, 2022
@mydea
mydea deleted the fn/replay-is-browser branch November 29, 2022 14:36
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@mydea@AbhiPrasad