Skip to content

build(replay): Generate Replay CDN bundles - #6391

Merged
Lms24 merged 8 commits into
masterfrom
lms-replay-build-cdnbundles
Dec 2, 2022
Merged

build(replay): Generate Replay CDN bundles#6391
Lms24 merged 8 commits into
masterfrom
lms-replay-build-cdnbundles

Conversation

@Lms24

@Lms24Lms24 commented Dec 2, 2022

Copy link
Copy Markdown
Member

This PR adds a rollup config to generate an addon CDN bundle for the Replay integration. Usage of this bundle is identical to our other integration CDN bundles in the sense that the bundle has to be added in addition to the regular browser (or browser+tracing) bundle.

As of this PR, three bundles will be generated into build/bundles:

  • replay.js (the unminified bundle with debug output)
  • replay.min.js(the minified bundle without debug output)
  • replay.debug.min.js (the minified bundle with debug output)

For now, we'll only generate ES6 bundles but we can add ES5 versions if requested later on.

ref #6362

Base automatically changed from lms-replay-WINDOW to masterDecember 2, 2022 10:06
Comment thread.size-limit.js
Comment threadpackages/replay/rollup.bundle.config.js Outdated
@github-actions

github-actionsBot commented Dec 2, 2022

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
@sentry/browser - ES5 CDN Bundle (gzipped + minified)19.57 KB (-0.02% 🔽)
@sentry/browser - ES5 CDN Bundle (minified)60.59 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified)18.36 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified)54.15 KB (0%)
@sentry/browser - Webpack (gzipped + minified)20.12 KB (0%)
@sentry/browser - Webpack (minified)65.75 KB (0%)
@sentry/react - Webpack (gzipped + minified)20.14 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified)45.95 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified)26.41 KB (-0.01% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified)24.85 KB (+0.02% 🔺)
@sentry/replay index.js0 B (removed)
@sentry/replay - Webpack (gzipped + minified)37.05 KB (0%)
@sentry/replay - Webpack (minified)0 B (removed)
@sentry/replay ES6 CDN Bundle (gzipped + minified)41.58 KB (added)

@Lms24Lms24 mentioned this pull request Dec 2, 2022
4 tasks

@lobsterkatielobsterkatie left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small questions, but otherwise LGTM!

Comment threadpackages/replay/package.json Outdated
Comment threadpackages/replay/rollup.bundle.config.js
Comment threadpackages/replay/src/index.ts Outdated
Comment threadpackages/replay/src/index.ts
Comment threadpackages/replay/src/constants.ts Outdated
Comment threadpackages/replay/rollup.bundle.config.js Outdated
@Lms24
Lms24force-pushed the lms-replay-build-cdnbundles branch 2 times, most recently from af20929 to b35efa8CompareDecember 2, 2022 11:36
@Lms24
Lms24force-pushed the lms-replay-build-cdnbundles branch from b35efa8 to 4080cd5CompareDecember 2, 2022 13:21
@Lms24
Lms24 enabled auto-merge (squash) December 2, 2022 13:46
@Lms24
Lms24 merged commit 3e7852e into masterDec 2, 2022
@Lms24
Lms24 deleted the lms-replay-build-cdnbundles branch December 2, 2022 13:47
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Lms24@mydea@lobsterkatie