Uh oh!
There was an error while loading. Please reload this page.
ref(replay): Split replay integration & container class - #6407
Conversation
| } | ||
| if (session.id !== this.session?.id) { | ||
| session.previousSessionId = this.session?.id; |
Check failure
Code scanning / CodeQL
Insecure randomness
size-limit report 📦
|
Lms24
left a comment
There was a problem hiding this comment.
I like the change because a) single responsibility is always good and b) (as we previously discussed) it gets us one step closer to converting the replay logic into a functional structure. We can start thinking about this if we have the time after we finish our other points on the roadmap. Added a point to #5326.
| describe('integration settings', () => { | ||
| describe('blockAllMedia', () => { | ||
| it('sets the correct configuration when `blockAllMedia` is disabled', async () => { | ||
| const { replay } = await mockSdk({ replayOptions: { blockAllMedia: false } }); |
There was a problem hiding this comment.
Good change (never knew that the previous syntax actually works 🤔 )
There was a problem hiding this comment.
yeah, we should prob. do that everywhere! But just stumbled over this because of some other refactoring made necessary here 😅
mydea
commented
Dec 5, 2022
Note: I also added an entry to the MIGRATION docs. |
Uh oh!
There was an error while loading. Please reload this page.
09c1797 to
23c964dCompare
A part of #6406, this splits up the main
index.tsfile of replay into two parts: