ref(replay): Enable `naming-convention` EsLint rule by Lms24 · Pull Request #6419 · getsentry/sentry-javascript

Lms24 · 2022-12-05T17:37:03Z

This PR re-activates the @typescript-eslint/naming-convention rule which ensures that all private class members are prefixed with _.

github-actions · 2022-12-05T17:49:24Z

size-limit report 📦

Path	Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified)	19.6 KB (-0.01% 🔽)
@sentry/browser - ES5 CDN Bundle (minified)	60.69 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified)	18.37 KB (+0.01% 🔺)
@sentry/browser - ES6 CDN Bundle (minified)	54.26 KB (0%)
@sentry/browser - Webpack (gzipped + minified)	20.13 KB (0%)
@sentry/browser - Webpack (minified)	65.83 KB (0%)
@sentry/react - Webpack (gzipped + minified)	20.16 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified)	47.01 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified)	26.44 KB (0%)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified)	24.87 KB (+0.02% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified)	41.57 KB (-0.31% 🔽)
@sentry/replay - Webpack (gzipped + minified)	37.23 KB (+0.06% 🔺)

Lms24 requested review from billyvg and mydea December 5, 2022 17:37

Lms24 mentioned this pull request Dec 5, 2022
[replay] Linting & code quality alignments #6323
Closed
6 tasks

Lms24 changed the title ~~ref(replay): Re-activate naming-convention EsLint rule~~ref(replay): Enable naming-convention EsLint ruleDec 5, 2022

billyvg approved these changes Dec 5, 2022
View reviewed changes

mydea approved these changes Dec 6, 2022
View reviewed changes

ref(replay): Enable naming-convention EsLint rule
9ae0002

Lms24 force-pushed the lms-replay-eslint-naming-convention branch from bd6096b to 9ae0002Compare December 6, 2022 10:45

Lms24 merged commit 7e05eb4 into masterDec 6, 2022

Lms24 deleted the lms-replay-eslint-naming-convention branch December 6, 2022 12:41