Skip to content

feat(core): Add addIntegration method to client - #6651

Merged
mydea merged 2 commits into
masterfrom
fn/addIntegration
Jan 5, 2023
Merged

feat(core): Add addIntegration method to client#6651
mydea merged 2 commits into
masterfrom
fn/addIntegration

Conversation

@mydea

@mydeamydea commented Jan 4, 2023

Copy link
Copy Markdown
Member

This can be used to add an integration at runtime.

This is useful e.g. for replay, where we may want to lazy load this (as the payload is quite large).

@mydea
mydea requested review from Lms24 and lforstJanuary 4, 2023 10:43
@mydeamydea self-assigned this Jan 4, 2023
@github-actions

github-actionsBot commented Jan 4, 2023

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
@sentry/browser - ES5 CDN Bundle (gzipped + minified)19.84 KB (+0.11% 🔺)
@sentry/browser - ES5 CDN Bundle (minified)61.43 KB (+0.15% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped + minified)18.61 KB (+0.09% 🔺)
@sentry/browser - ES6 CDN Bundle (minified)54.98 KB (+0.13% 🔺)
@sentry/browser - Webpack (gzipped + minified)20.38 KB (+0.11% 🔺)
@sentry/browser - Webpack (minified)66.62 KB (+0.14% 🔺)
@sentry/react - Webpack (gzipped + minified)20.41 KB (+0.1% 🔺)
@sentry/nextjs Client - Webpack (gzipped + minified)47.65 KB (+0.05% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified)26.81 KB (+0.11% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified)25.25 KB (+0.11% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified)42.99 KB (-0.02% 🔽)
@sentry/replay - Webpack (gzipped + minified)38.24 KB (+0.01% 🔺)

Comment threadpackages/types/src/client.ts

@Lms24Lms24 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks like bundle size impact is negligible so I'd say let's go for it!

Comment threadpackages/types/src/client.ts
This can be used to add an integration at run time.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@mydea@jassonbla@lforst@Lms24