Skip to content

fix(nextjs): Disable NextJS perf monitoring when using otel - #6820

Merged
AbhiPrasad merged 2 commits into
masterfrom
abhi-disable-nextjs-otel
Jan 17, 2023
Merged

fix(nextjs): Disable NextJS perf monitoring when using otel#6820
AbhiPrasad merged 2 commits into
masterfrom
abhi-disable-nextjs-otel

Conversation

@AbhiPrasad

@AbhiPrasadAbhiPrasad commented Jan 17, 2023

Copy link
Copy Markdown
Contributor

Blocks release in #6818 as well

Only instrument NextJS data fetchers for performance if the instrumenter is set to sentry (default).

@AbhiPrasad
AbhiPrasadforce-pushed the abhi-disable-nextjs-otel branch from 51eddd9 to 402d53fCompareJanuary 17, 2023 11:35
@github-actions

github-actionsBot commented Jan 17, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
@sentry/browser - ES5 CDN Bundle (gzipped + minified)19.82 KB (+0.01% 🔺)
@sentry/browser - ES5 CDN Bundle (minified)61.47 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified)18.5 KB (+0.01% 🔺)
@sentry/browser - ES6 CDN Bundle (minified)54.77 KB (0%)
@sentry/browser - Webpack (gzipped + minified)20.22 KB (0%)
@sentry/browser - Webpack (minified)66.17 KB (0%)
@sentry/react - Webpack (gzipped + minified)20.24 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified)47.51 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified)26.73 KB (-0.02% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified)25.02 KB (+0.01% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified)43.12 KB (-0.83% 🔽)
@sentry/replay - Webpack (gzipped + minified)38.45 KB (-0.99% 🔽)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified)60.35 KB (-0.6% 🔽)

@lforst

lforst commented Jan 17, 2023

Copy link
Copy Markdown
Contributor

Tests are failing :'(

@lforstlforst mentioned this pull request Jan 17, 2023
Merged
@AbhiPrasad

AbhiPrasad commented Jan 17, 2023

Copy link
Copy Markdown
ContributorAuthor

Fixed test failures with e967714!

@AbhiPrasadAbhiPrasad changed the title feat(nextjs): Disable NextJS perf monitoring when using otelfix(nextjs): Disable NextJS perf monitoring when using otelJan 17, 2023
@AbhiPrasad
AbhiPrasad enabled auto-merge (squash) January 17, 2023 12:15
@AbhiPrasad
AbhiPrasad merged commit 7d43873 into masterJan 17, 2023
@AbhiPrasad
AbhiPrasad deleted the abhi-disable-nextjs-otel branch January 17, 2023 12:16
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mydeamydeamydea approved these changes
@lforstlforstAwaiting requested review from lforst

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AbhiPrasad@lforst@mydea