Uh oh!
There was an error while loading. Please reload this page.
chore: metrics collection job should also run on develop - #6882
Merged
Conversation
mydea
reviewed
Jan 20, 2023
Uh oh!
There was an error while loading. Please reload this page.
vaindforce-pushed
the
chore/metrics-main-branch
branch
2 times, most recently
from
January 20, 2023 09:35
33c5ce8 to
7e16123Comparevaind
marked this pull request as ready for review
January 20, 2023 09:35
Lms24
previously approved these changes
Feb 1, 2023
mydea
commented
Feb 2, 2023
Member
In the meanwhile we changed the main branch to develop (I updated the PR target). please rebase this on latest develop, and change |
vaindforce-pushed
the
chore/metrics-main-branch
branch
from
February 2, 2023 19:48
7e16123 to
caf4a03Comparevaindforce-pushed
the
chore/metrics-main-branch
branch
from
February 2, 2023 19:49
caf4a03 to
4a7cd8eComparevaind
commented
Feb 2, 2023
ContributorAuthor
done |
Lms24
approved these changes
Feb 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous PR that introduces the Replay SDK metrics job already contained code that collected baseline info from the main branch.
However, after making a change to only run when a specific label is added, this feature got lost...
This PR should fix that.