Uh oh!
There was an error while loading. Please reload this page.
test(nextjs): Refactor server-side integration tests - #6909
Merged
Conversation
| // This test asserts that our wrapping of `res.end` doesn't break API routes on Vercel if people call `res.json` or | ||
| // `res.send` multiple times in one request handler. | ||
| // https://github.com/getsentry/sentry-javascript/issues/6670 | ||
| it.skip('should not break API routes on Vercel if people call res.json or res.send multiple times in one request handler', async () => { |
ContributorAuthor
There was a problem hiding this comment.
This test randomly fails with ERR_STREAM_WRITE_AFTER_END, not sure if it's the testing environment or the case in #6099 still happens.
Contributor
There was a problem hiding this comment.
Yeah I think this is an actual bug in the SDK
Contributor
size-limit report 📦
|
onurtemizkanforce-pushed
the
onur/nextjs-new-server-integration-tests
branch
3 times, most recently
from
January 24, 2023 11:19
7abc57f to
5fb8ac2Compareonurtemizkanforce-pushed
the
onur/nextjs-new-server-integration-tests
branch
2 times, most recently
from
January 25, 2023 11:53
2ecc14b to
e6b9f4dCompareonurtemizkanforce-pushed
the
onur/nextjs-new-server-integration-tests
branch
from
January 25, 2023 12:28
e6b9f4d to
be99114Compareonurtemizkan
requested review from
AbhiPrasad and lforst
and removed request for
AbhiPrasadJanuary 25, 2023 12:52
onurtemizkan
marked this pull request as ready for review
January 25, 2023 12:53
5 tasks
lforst
approved these changes
Jan 25, 2023
lforst
commented
Jan 25, 2023
Contributor
Thanks Onur! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: #6053
node-integration-testspackage.next.configtemplate / environment configuration forappDirtests.