Uh oh!
There was an error while loading. Please reload this page.
Don't assume previous shouldSendCallback exists in RN plugin (fixes #692) - #694
Conversation
benvinegar
commented
Aug 18, 2016
This change will mean that if I'm not 100% sure if this is the intended behavior or not. Need someone more familiar to chime off on this (@nevir). |
benvinegar
commented
Aug 18, 2016
Re-reading the code, I understand now that this code branch is reached if we're dealing with a non-fatal, in which case we should return |
nevir
commented
Aug 18, 2016
Yup! This looks correct |
benvinegar
commented
Aug 18, 2016
wfm! 3.5.1 going out soon |
cc @marcello3d@nevir@logicalicy@macqueen
This change is