Skip to content

ci: Fix invalid yaml - #7034

Merged
mydea merged 2 commits into
developfrom
fn/ci-fix-develop-sync
Feb 2, 2023
Merged

ci: Fix invalid yaml#7034
mydea merged 2 commits into
developfrom
fn/ci-fix-develop-sync

Conversation

@mydea

@mydeamydea commented Feb 2, 2023

Copy link
Copy Markdown
Member

It seems to not like double quotes.

See e.g. https://github.com/getsentry/sentry-javascript/actions/runs/4072470708

The workflow is not valid. .github/workflows/gitflow-sync-master.yml (Line: 16, Col: 9): Unexpected symbol: '"meta'. Located at position 89 within expression: github.event.pull_request.merged == true
&& startsWith(github.event.pull_request.title, "meta(changelog):")
.github/workflows/gitflow-sync-master.yml (Line: 57, Col: 9): Unexpected symbol: '"meta'. Located at position 90 within expression: github.event.pull_request.merged == false
|| startsWith(github.event.pull_request.title, "meta(changelog):") == false

Note: This also fixes an incorrect check which meant we weren't running CI for all prs.

@mydeamydea self-assigned this Feb 2, 2023
It seems to not like double quotes.
@mydea
mydeaforce-pushed the fn/ci-fix-develop-sync branch 3 times, most recently from 7a8b90f to 25497a1CompareFebruary 2, 2023 09:24
@mydea
mydeaforce-pushed the fn/ci-fix-develop-sync branch from 25497a1 to 7df265cCompareFebruary 2, 2023 09:26
@mydea
mydea enabled auto-merge (squash) February 2, 2023 09:29
@Lms24Lms24 mentioned this pull request Feb 2, 2023
@github-actions

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
@sentry/browser - ES5 CDN Bundle (gzipped + minified)19.91 KB (+0.19% 🔺)
@sentry/browser - ES5 CDN Bundle (minified)61.72 KB (+0.24% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped + minified)18.59 KB (+0.26% 🔺)
@sentry/browser - ES6 CDN Bundle (minified)55.02 KB (+0.26% 🔺)
@sentry/browser - Webpack (gzipped + minified)20.32 KB (+0.14% 🔺)
@sentry/browser - Webpack (minified)66.48 KB (+0.17% 🔺)
@sentry/react - Webpack (gzipped + minified)20.35 KB (+0.16% 🔺)
@sentry/nextjs Client - Webpack (gzipped + minified)47.64 KB (+0.08% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified)26.82 KB (+0.1% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified)25.12 KB (+0.17% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified)43.85 KB (+0.1% 🔺)
@sentry/replay - Webpack (gzipped + minified)38.76 KB (+0.12% 🔺)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified)61.48 KB (+0.12% 🔺)

@mydea
mydea merged commit 7532522 into developFeb 2, 2023
@mydea
mydea deleted the fn/ci-fix-develop-sync branch February 2, 2023 09:45
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@mydea@Lms24