Skip to content

feat(replay): Improve ignoring of rrweb-internal errors - #7094

Merged
mydea merged 2 commits into
developfrom
fn/update-rrweb
Feb 9, 2023
Merged

feat(replay): Improve ignoring of rrweb-internal errors#7094
mydea merged 2 commits into
developfrom
fn/update-rrweb

Conversation

@mydea

@mydeamydea commented Feb 8, 2023

Copy link
Copy Markdown
Member

This updates rrweb to https://github.com/getsentry/rrweb/releases/tag/1.101.0, which mainly improves our wrapping of rrweb errors.

@mydea
mydea requested review from Lms24 and billyvgFebruary 8, 2023 14:39
@mydeamydea self-assigned this Feb 8, 2023
@github-actions

github-actionsBot commented Feb 8, 2023

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
@sentry/browser - ES5 CDN Bundle (gzipped + minified)20.06 KB (-0.01% 🔽)
@sentry/browser - ES5 CDN Bundle (minified)62.19 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified)18.69 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified)55.33 KB (0%)
@sentry/browser - Webpack (gzipped + minified)20.42 KB (0%)
@sentry/browser - Webpack (minified)66.77 KB (0%)
@sentry/react - Webpack (gzipped + minified)20.45 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified)47.74 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified)26.97 KB (-0.01% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified)25.23 KB (-0.01% 🔽)
@sentry/replay ES6 CDN Bundle (gzipped + minified)42.23 KB (-3.76% 🔽)
@sentry/replay - Webpack (gzipped + minified)36.65 KB (-5.53% 🔽)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified)59.9 KB (-2.77% 🔽)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified)53.44 KB (-3.06% 🔽)

@Lms24

Lms24 commented Feb 8, 2023

Copy link
Copy Markdown
Member

How does this reduce bundle size so much 🤔

@mydea

mydea commented Feb 9, 2023

Copy link
Copy Markdown
MemberAuthor

How does this reduce bundle size so much 🤔

Yeah, I also wondered about this 😅

This updates rrweb to https://github.com/getsentry/rrweb/releases/tag/1.101.0, which mainly improves our wrapping of rrweb errors.
@mydea
mydea merged commit 9fb6d0d into developFeb 9, 2023
@mydea
mydea deleted the fn/update-rrweb branch February 9, 2023 09:57
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@mydea@Lms24@billyvg