Skip to content

test(replay): Test against full and errors+replay CDN bundles - #7096

Merged
Lms24 merged 6 commits into
developfrom
lms-replay-pw-add-bundles
Feb 13, 2023
Merged

test(replay): Test against full and errors+replay CDN bundles#7096
Lms24 merged 6 commits into
developfrom
lms-replay-pw-add-bundles

Conversation

@Lms24

@Lms24Lms24 commented Feb 8, 2023

Copy link
Copy Markdown
Member

This PR updates our Playwright test setup to test against four new SDK CDN bundles:

  • SDK+Tracing+Replay
  • SDK+Tracing+Replay minified
  • SDK+Replay
  • SDK+Replay minified

To make this work and simplify our test case inits, I decided to drop testing against the replay addon CDN bundle which we recently decided to deprecate in favour of the full bundles. This has the nice side effect that our PW setup is slightly simplified.

Overall, this change adds four more PW test jobs to CI but I've checked runtime and the impact seems negligible.

ref #7044

Also, cc @billyvg - once this is merged, I think #7055 should work better. You might need to update your init.js file.

@Lms24
Lms24force-pushed the lms-replay-pw-add-bundles branch from 616bb48 to dda86baCompareFebruary 9, 2023 10:16
@github-actions

github-actionsBot commented Feb 9, 2023

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
@sentry/browser - ES5 CDN Bundle (gzipped + minified)20.07 KB (+0.02% 🔺)
@sentry/browser - ES5 CDN Bundle (minified)62.2 KB (+0.02% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped + minified)18.7 KB (+0.02% 🔺)
@sentry/browser - ES6 CDN Bundle (minified)55.34 KB (+0.02% 🔺)
@sentry/browser - Webpack (gzipped + minified)20.43 KB (+0.04% 🔺)
@sentry/browser - Webpack (minified)66.78 KB (+0.02% 🔺)
@sentry/react - Webpack (gzipped + minified)20.46 KB (+0.04% 🔺)
@sentry/nextjs Client - Webpack (gzipped + minified)47.85 KB (+0.02% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified)26.98 KB (+0.03% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified)25.24 KB (+0.03% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified)42.28 KB (0%)
@sentry/replay - Webpack (gzipped + minified)36.7 KB (0%)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified)59.93 KB (+0.01% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified)53.49 KB (+0.02% 🔺)

@getsentrygetsentry deleted a comment from github-actionsBotFeb 9, 2023
@Lms24
Lms24force-pushed the lms-replay-pw-add-bundles branch from dda86ba to 4f53323CompareFebruary 9, 2023 10:35
@Lms24
Lms24force-pushed the lms-replay-pw-add-bundles branch 2 times, most recently from 702c517 to 043a358CompareFebruary 9, 2023 12:37
@Lms24
Lms24force-pushed the lms-replay-pw-add-bundles branch from 043a358 to 18eeb79CompareFebruary 10, 2023 09:19
@Lms24
Lms24force-pushed the lms-replay-pw-add-bundles branch from 18eeb79 to 9b5710eCompareFebruary 10, 2023 09:19
@Lms24
Lms24force-pushed the lms-replay-pw-add-bundles branch from 088eef7 to 7bec22fCompareFebruary 10, 2023 10:30
@Lms24Lms24 changed the title [Ignore] test(replay): Test against full and errors+replay CDN bundlestest(replay): Test against full and errors+replay CDN bundlesFeb 10, 2023
@Lms24
Lms24 requested review from billyvg and mydeaFebruary 10, 2023 10:36
@Lms24
Lms24 marked this pull request as ready for review February 10, 2023 10:51
@Lms24
Lms24 merged commit 7a332e4 into developFeb 13, 2023
@Lms24
Lms24 deleted the lms-replay-pw-add-bundles branch February 13, 2023 11:04
@Lms24

Copy link
Copy Markdown
MemberAuthor

oof accidentally selected merge instead of squash+rebase, sorry about that 🙈

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Lms24@billyvg