Skip to content

fix(replay): Update worker.js to remove console log - #7098

Merged
Lms24 merged 1 commit into
developfrom
lms-replay-unstale-worker
Feb 8, 2023
Merged

fix(replay): Update worker.js to remove console log#7098
Lms24 merged 1 commit into
developfrom
lms-replay-unstale-worker

Conversation

@Lms24

@Lms24Lms24 commented Feb 8, 2023

Copy link
Copy Markdown
Member

Remember this from my last PR #7082?

Note: Not sure why the worker.js file changed

LOL, now we know. I temporarily added a console.log statement in the worker's compressor, triggering a new worker build. For whatever reason, after removing the log statement, I didn't build the worker again, letting this log statement end up in develop

@Lms24
Lms24 requested a review from mydeaFebruary 8, 2023 15:56
@Lms24Lms24 changed the title fix(replay): Update logger.js to remove console logfix(replay): Update worker.js to remove console logFeb 8, 2023
@Lms24
Lms24force-pushed the lms-replay-unstale-worker branch from 0b36f7b to dfdc36eCompareFebruary 8, 2023 15:58
@Lms24
Lms24force-pushed the lms-replay-unstale-worker branch from dfdc36e to 717a4cfCompareFebruary 8, 2023 15:58
@github-actions

Copy link
Copy Markdown
Contributor

Replay SDK metrics 🚀

Plain+Sentry+Replay
RevisionValueValueDiffRatioValueDiffRatio
LCPThis PR 45638e488.20 ms128.36 ms+40.16 ms+45.53 %160.00 ms+71.80 ms+81.41 %
Previous b539b3691.57 ms120.17 ms+28.60 ms+31.23 %145.54 ms+53.97 ms+58.94 %
CLSThis PR 45638e40.06 ms0.06 ms-0.00 ms-0.04 %0.06 ms+0.00 ms+0.01 %
Previous b539b360.06 ms0.06 ms-0.00 ms-0.38 %0.06 ms-0.00 ms-0.41 %
CPUThis PR 45638e420.63 %22.09 %+1.46 pp+7.08 %42.57 %+21.94 pp+106.31 %
Previous b539b3620.10 %20.34 %+0.24 pp+1.21 %36.63 %+16.53 pp+82.26 %
JS heap avgThis PR 45638e41.93 MB2 MB+68.89 kB+3.56 %3.03 MB+1.1 MB+56.71 %
Previous b539b361.94 MB2 MB+60.28 kB+3.11 %3.06 MB+1.12 MB+57.77 %
JS heap maxThis PR 45638e42.3 MB2.56 MB+261.89 kB+11.37 %4.57 MB+2.26 MB+98.25 %
Previous b539b362.31 MB2.58 MB+277.13 kB+12.02 %4.54 MB+2.23 MB+96.89 %
netTxThis PR 45638e40 B0 B0 Bn/a2.61 kB+2.61 kBn/a
Previous b539b360 B0 B0 Bn/a2.61 kB+2.61 kBn/a
netRxThis PR 45638e40 B0 B0 Bn/a41 B+41 Bn/a
Previous b539b360 B0 B0 Bn/a41 B+41 Bn/a
netCountThis PR 45638e4000n/a1+1n/a
Previous b539b36000n/a1+1n/a
netTimeThis PR 45638e40.00 ms0.00 ms0.00 msn/a98.15 ms+98.15 msn/a
Previous b539b360.00 ms0.00 ms0.00 msn/a114.29 ms+114.29 msn/a

Previous results on branch: develop

RevisionLCPCLSCPUJS heap avgJS heap maxnetTxnetRxnetCountnetTime
b539b36+53.97 ms-0.00 ms+16.53 pp+1.12 MB+2.23 MB+2.61 kB+41 B+1+114.29 ms
6462b00+62.18 ms+0.00 ms+23.70 pp+1.1 MB+2.23 MB+2.57 kB+41 B+1+117.17 ms

*) pp - percentage points - an absolute difference between two percentages.
Last updated: Wed, 08 Feb 2023 15:59:08 GMT

@Lms24
Lms24 merged commit 5c937aa into developFeb 8, 2023
@Lms24
Lms24 deleted the lms-replay-unstale-worker branch February 8, 2023 17:23
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Lms24@mydea@AbhiPrasad