Skip to content

fix(replay): Export Replay from Sentry namespace in full CDN bundle - #7119

Merged
Lms24 merged 3 commits into
developfrom
lms-fix-replay-full-bundle-export
Feb 9, 2023
Merged

fix(replay): Export Replay from Sentry namespace in full CDN bundle#7119
Lms24 merged 3 commits into
developfrom
lms-fix-replay-full-bundle-export

Conversation

@Lms24

@Lms24Lms24 commented Feb 9, 2023

Copy link
Copy Markdown
Member

To be consistent with export namespaces, we want the Replay integration to be accesible under Sentry.Replay in the full CDN bundles. This is backwards compatible as we still permit Sentry.Integrations.Replay as well. We can remove it in v8.

With this change, both CDN bundles containing replay (sdk+tracing+replay and sdk+replay) export from Sentry.Replay. Only the addon bundle, which we already deprecated and don't mention in the docs anymore will only be available i nSentry.Integrations.Replay.

@Lms24
Lms24 requested a review from mydeaFebruary 9, 2023 14:41
@github-actions

Copy link
Copy Markdown
Contributor

Replay SDK metrics 🚀

Plain+Sentry+Replay
RevisionValueValueDiffRatioValueDiffRatio
LCPThis PR e9c799b89.57 ms121.60 ms+32.02 ms+35.75 %140.30 ms+50.72 ms+56.63 %
Previous fc7b71687.40 ms117.55 ms+30.15 ms+34.50 %139.84 ms+52.44 ms+60.00 %
CLSThis PR e9c799b0.06 ms0.06 ms-0.00 ms-0.35 %0.06 ms-0.00 ms-0.43 %
Previous fc7b7160.06 ms0.06 ms-0.00 ms-0.05 %0.06 ms+0.00 ms+0.17 %
CPUThis PR e9c799b22.28 %21.74 %-0.54 pp-2.43 %38.25 %+15.96 pp+71.64 %
Previous fc7b71623.43 %21.43 %-2.00 pp-8.52 %38.17 %+14.74 pp+62.91 %
JS heap avgThis PR e9c799b1.94 MB2 MB+61.55 kB+3.17 %3.03 MB+1.09 MB+56.25 %
Previous fc7b7161.94 MB2.06 MB+116.41 kB+6.00 %3.03 MB+1.09 MB+56.28 %
JS heap maxThis PR e9c799b2.3 MB2.56 MB+255.16 kB+11.08 %4.5 MB+2.2 MB+95.36 %
Previous fc7b7162.3 MB2.58 MB+271.73 kB+11.79 %4.51 MB+2.21 MB+95.72 %
netTxThis PR e9c799b0 B0 B0 Bn/a2.61 kB+2.61 kBn/a
Previous fc7b7160 B0 B0 Bn/a2.68 kB+2.68 kBn/a
netRxThis PR e9c799b0 B0 B0 Bn/a41 B+41 Bn/a
Previous fc7b7160 B0 B0 Bn/a41 B+41 Bn/a
netCountThis PR e9c799b000n/a1+1n/a
Previous fc7b716000n/a1+1n/a
netTimeThis PR e9c799b0.00 ms0.00 ms0.00 msn/a94.97 ms+94.97 msn/a
Previous fc7b7160.00 ms0.00 ms0.00 msn/a89.64 ms+89.64 msn/a

Previous results on branch: develop

RevisionLCPCLSCPUJS heap avgJS heap maxnetTxnetRxnetCountnetTime
fc7b716+52.44 ms+0.00 ms+14.74 pp+1.09 MB+2.21 MB+2.68 kB+41 B+1+89.64 ms

*) pp - percentage points - an absolute difference between two percentages.
Last updated: Thu, 09 Feb 2023 14:43:10 GMT

@github-actions

github-actionsBot commented Feb 9, 2023

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
@sentry/browser - ES5 CDN Bundle (gzipped + minified)20.06 KB (0%)
@sentry/browser - ES5 CDN Bundle (minified)62.19 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified)18.69 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified)55.33 KB (0%)
@sentry/browser - Webpack (gzipped + minified)20.42 KB (0%)
@sentry/browser - Webpack (minified)66.77 KB (0%)
@sentry/react - Webpack (gzipped + minified)20.45 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified)47.74 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified)26.97 KB (-0.01% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified)25.23 KB (-0.01% 🔽)
@sentry/replay ES6 CDN Bundle (gzipped + minified)42.28 KB (0%)
@sentry/replay - Webpack (gzipped + minified)36.7 KB (0%)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified)59.93 KB (-0.02% 🔽)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified)53.48 KB (0%)

@Lms24
Lms24 merged commit a9bf858 into developFeb 9, 2023
@Lms24
Lms24 deleted the lms-fix-replay-full-bundle-export branch February 9, 2023 15:11
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Lms24@AbhiPrasad