Skip to content

fix(replay): Fix svgs not getting unblocked - #7132

Merged
billyvg merged 2 commits into
developfrom
fix-replay-svg-unblock-overridden
Feb 10, 2023
Merged

fix(replay): Fix svgs not getting unblocked #7132
billyvg merged 2 commits into
developfrom
fix-replay-svg-unblock-overridden

Conversation

@billyvg

@billyvgbillyvg commented Feb 10, 2023•
edited
Loading

Copy link
Copy Markdown
Member

This fixes an issue found in #7020 where unblock was not working for SVGs. This was due to our default media selectors including svg child elements. rrweb will handle blocking these as needed when the parent SVG is blocked.

@billyvg
billyvg changed the base branch from develop to feat-replay-add-privacy-testFebruary 10, 2023 00:23
@billyvgbillyvg changed the title fix replay svg unblock overriddenfix(replay): Fix svgs not getting unblocked Feb 10, 2023
@billyvg

billyvg commented Feb 10, 2023

Copy link
Copy Markdown
MemberAuthor

Requires #7055

@github-actions

github-actionsBot commented Feb 10, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
@sentry/browser - ES5 CDN Bundle (gzipped + minified)20.07 KB (-0.01% 🔽)
@sentry/browser - ES5 CDN Bundle (minified)62.2 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified)18.7 KB (-0.02% 🔽)
@sentry/browser - ES6 CDN Bundle (minified)55.34 KB (0%)
@sentry/browser - Webpack (gzipped + minified)20.43 KB (0%)
@sentry/browser - Webpack (minified)66.78 KB (0%)
@sentry/react - Webpack (gzipped + minified)20.46 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified)47.85 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified)26.99 KB (-0.01% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified)25.24 KB (-0.01% 🔽)
@sentry/replay ES6 CDN Bundle (gzipped + minified)42.26 KB (-0.03% 🔽)
@sentry/replay - Webpack (gzipped + minified)36.69 KB (-0.03% 🔽)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified)59.93 KB (-0.02% 🔽)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified)53.48 KB (-0.03% 🔽)

@billyvg
billyvg marked this pull request as ready for review February 10, 2023 00:54
@billyvg
billyvg requested review from Lms24 and mydeaFebruary 10, 2023 00:54
mydea
mydea approved these changes Feb 10, 2023
View reviewed changes

@mydeamydea left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Def. makes sense!

Base automatically changed from feat-replay-add-privacy-test to developFebruary 10, 2023 14:34
@billyvg
fix(replay): Fix svgs not getting unblocked
3a0ef88
This fixes an issue found in #7020 where `unblock` was not working for SVGs. This was due to our default media selectors including svg child elements. rrweb will handle blocking these as needed when the parent SVG is blocked.
@billyvg
update tests
5232cef
@billyvg
billyvgforce-pushed the fix-replay-svg-unblock-overridden branch from d3d164f to 5232cefCompareFebruary 10, 2023 14:41
@billyvg
billyvg merged commit 93c4759 into developFeb 10, 2023
@billyvg
billyvg deleted the fix-replay-svg-unblock-overridden branch February 10, 2023 15:37
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mydeamydeamydea approved these changes
@Lms24Lms24Awaiting requested review from Lms24

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@billyvg@mydea