Uh oh!
There was an error while loading. Please reload this page.
fix(replay): Fix missing fetch/xhr requests - #7134
Merged
Merged
Conversation
Logic was flipped for the filter function so fetch and xhr requests were not being recorded at all.
billyvg
commented
Feb 10, 2023
MemberAuthor
We should add an integration test for this. |
Contributor
size-limit report 📦
|
mydea
approved these changes
Feb 10, 2023
mydea
left a comment
Member
There was a problem hiding this comment.
Damn, good catch! filter boolean responses are always a bit ambiguous 😬
Contributor
Replay SDK metrics 🚀
develop | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Revision | LCP | CLS | CPU | JS heap avg | JS heap max | netTx | netRx | netCount | netTime |
|---|---|---|---|---|---|---|---|---|---|
| b49d9f7 | +52.79 ms | -0.00 ms | +15.46 pp | +1.07 MB | +2.21 MB | +2.59 kB | +41 B | +1 | +70.48 ms |
| 7e57cb7 | +47.89 ms | +0.00 ms | +10.59 pp | +1.09 MB | +2.21 MB | +2.59 kB | +41 B | +1 | +72.93 ms |
| 538c3a6 | +63.63 ms | +0.00 ms | +14.14 pp | +1.07 MB | +2.16 MB | +2.6 kB | +41 B | +1 | +112.08 ms |
| fc7b716 | +52.44 ms | +0.00 ms | +14.74 pp | +1.09 MB | +2.21 MB | +2.68 kB | +41 B | +1 | +89.64 ms |
*) pp - percentage points - an absolute difference between two percentages.
Last updated: Fri, 10 Feb 2023 10:44:36 GMT
Last updated: Fri, 10 Feb 2023 10:44:36 GMT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Logic was flipped for the filter function so fetch and xhr requests were not being recorded at all.
Closeshttps://github.com/getsentry/team-replay/issues/9
Closes#7078