Uh oh!
There was an error while loading. Please reload this page.
test(wasm): Move WASM test to Playwright and remove Puppeteer - #7217
Merged
Conversation
Lms24
requested review from
a team, AbhiPrasad and lforst
and removed request for
a teamFebruary 17, 2023 11:38
AbhiPrasad
approved these changes
Feb 17, 2023
AbhiPrasad
left a comment
Contributor
There was a problem hiding this comment.
Nice - like the usage of playwright to serve the wasm file
Lms24force-pushed
the
lms/mv-wasm-integration-tests
branch
from
February 17, 2023 11:50
a1a0c1c to
d0ccf02CompareContributor
Replay SDK metrics 🚀
develop | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Revision | LCP | CLS | CPU | JS heap avg | JS heap max | netTx | netRx | netCount | netTime |
|---|---|---|---|---|---|---|---|---|---|
| 09c6cbe | +52.51 ms | +0.00 ms | +8.15 pp | +925.44 kB | +1.06 MB | +2.22 kB | +41 B | +1 | +76.58 ms |
| 1cf8988 | +53.81 ms | -0.00 ms | +4.80 pp | +929.88 kB | +1.05 MB | +2.22 kB | +41 B | +1 | +91.07 ms |
| 68655e3 | +72.60 ms | +0.00 ms | +7.90 pp | +922.72 kB | +1.04 MB | +2.22 kB | +41 B | +1 | +109.40 ms |
| a8449de | +58.27 ms | -0.00 ms | +7.12 pp | +927.42 kB | +1.05 MB | +2.2 kB | +41 B | +1 | +98.31 ms |
| 79babe9 | +58.69 ms | -0.00 ms | +4.40 pp | +927.46 kB | +1.06 MB | +2.23 kB | +41 B | +1 | +103.20 ms |
| 5359ba9 | +55.62 ms | -0.00 ms | +4.29 pp | +935.26 kB | +1.05 MB | +2.2 kB | +41 B | +1 | +79.05 ms |
*) pp - percentage points - an absolute difference between two percentages.
Last updated: Fri, 17 Feb 2023 12:10:43 GMT
Last updated: Fri, 17 Feb 2023 12:10:43 GMT
mydea
approved these changes
Feb 17, 2023
mydea
left a comment
Member
There was a problem hiding this comment.
nice, great to get rid of this and streamline this 🎉
Lms24force-pushed
the
lms/mv-wasm-integration-tests
branch
from
February 17, 2023 13:23
d0ccf02 to
a1169a1CompareLms24force-pushed
the
lms/mv-wasm-integration-tests
branch
from
February 17, 2023 13:54
a1169a1 to
4ece78aCompareContributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the integration test for our WASM integration to our Playwright browser integration test suite. With this change we finally get rid of Puppeteer in our monorepo.
For this to work, I had to make a few adjustments:
@sentry/integrationsbundles to Playwright templates #6666), we can now also inject the WASM integration bundle into our test fixturesfetch(simple.wasm)to load the WASM module anymore like we used to in puppeteer. Instead, we fake an http request and return the WASM module in the response (seetest.ts).Generally, I had to make some adjustments to translate the old test setup to our PW tests but I tried to keep changes minimal and the core test didn't change at all.
Because this test was the only test in the WASM package, we can get rid of quite a few files.
closes#6054