Uh oh!
There was an error while loading. Please reload this page.
feat(replay): Add more default block filters - #7233
Conversation
Replay SDK metrics 🚀
develop | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Revision | LCP | CLS | CPU | JS heap avg | JS heap max | netTx | netRx | netCount | netTime |
|---|---|---|---|---|---|---|---|---|---|
| 12e34d4 | +28.57 ms | +0.00 ms | +5.77 pp | +930.12 kB | +1.04 MB | +2.26 kB | +41 B | +1 | +109.67 ms |
| c46c56c | +65.45 ms | -0.00 ms | +5.38 pp | +930.26 kB | +1.07 MB | +2.21 kB | +41 B | +1 | +91.29 ms |
| 7f4c4ec | +56.64 ms | -0.00 ms | +5.57 pp | +927.42 kB | +1.06 MB | +2.21 kB | +41 B | +1 | +110.83 ms |
| 00d2360 | +55.18 ms | +0.00 ms | +2.23 pp | +934.14 kB | +1.05 MB | +2.22 kB | +41 B | +1 | +71.65 ms |
Last updated: Mon, 20 Feb 2023 15:38:22 GMT
Uh oh!
There was an error while loading. Please reload this page.
mydea
commented
Feb 21, 2023
Ah, some tests are failing - can you take a look at fixing them? if not or if unsure where to look, let me know, then I'll see when I get to it! |
Not entirely sure if tests will pass (my machine keeps dying during tests 😅) but I fixed some of them (I believe if there's any issue it may be related to the outdated snapshot) If tests fail I'll fix it tomorrow : ) |
lucas-zimerman
commented
Feb 22, 2023
@mydea Tests are now fixed : ) |
mydea
commented
Feb 22, 2023
Thanks a lot! I promoted this to a |
This adds the following block filters:
The link icons could be removed since they're not visible from the Sentry Replay UI.
The base href is removing the localhost references that causes CSP errors at Sentry as seen here #7184 and here #7183 (comment)
The base[href="/"] filter makes sense for apps that are using Sentry/Javascript since the tools usually adds a localhost reference and that causes the Sentry Website to have CSP errors.
Additionally, I have validated it locally with the Replay Sample/Demo but I am unsure how should I add tests for those items.
Before submitting a pull request, please take a look at our
Maybe in the future, consider adding ways for sibling SDKs to add additional block parameters so that the main Replay doesn't include filters from platform specific code.
Contributing guidelines and verify:
yarn lint) & (yarn test).(Yarn test is not passing locally because the machine is running out of memory and there's a test that seems to be time sensitive)