Uh oh!
There was an error while loading. Please reload this page.
fix(ember): Disable performance in FastBoot - #7282
Conversation
We do not want to run the instance initializer in fastboot env, as that relies on Browser stuff.
Lms24
left a comment
There was a problem hiding this comment.
TIL about Ember fastboot
Makes sense to me
Replay SDK metrics 🚀
develop | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Revision | LCP | CLS | CPU | JS heap avg | JS heap max | netTx | netRx | netCount | netTime |
|---|---|---|---|---|---|---|---|---|---|
| 4b95c04 | +57.56 ms | -0.00 ms | +7.94 pp | +920.88 kB | +1.05 MB | +2.21 kB | +41 B | +1 | +90.32 ms |
| e60cd02 | +56.25 ms | -0.00 ms | +6.32 pp | +927.44 kB | +1.06 MB | +2.21 kB | +41 B | +1 | +117.55 ms |
| e25c067 | +48.34 ms | +0.00 ms | +5.59 pp | +926.37 kB | +1.05 MB | +2.22 kB | +41 B | +1 | +65.23 ms |
| b1b249b | +43.88 ms | +0.00 ms | +4.80 pp | +937.99 kB | +1.05 MB | +2.22 kB | +41 B | +1 | +111.56 ms |
| 12e34d4 | +28.57 ms | +0.00 ms | +5.77 pp | +930.12 kB | +1.04 MB | +2.26 kB | +41 B | +1 | +109.67 ms |
| c46c56c | +65.45 ms | -0.00 ms | +5.38 pp | +930.26 kB | +1.07 MB | +2.21 kB | +41 B | +1 | +91.29 ms |
| 7f4c4ec | +56.64 ms | -0.00 ms | +5.57 pp | +927.42 kB | +1.06 MB | +2.21 kB | +41 B | +1 | +110.83 ms |
| 00d2360 | +55.18 ms | +0.00 ms | +2.23 pp | +934.14 kB | +1.05 MB | +2.22 kB | +41 B | +1 | +71.65 ms |
Last updated: Mon, 27 Feb 2023 13:51:43 GMT
k-fish
commented
Feb 27, 2023
@mydea sounds good. I suspect we will eventually want SSR similar to nextjs for all our js sdk's since it's part of the performance lifetime of the user action still (and ssr can be where all the slowness lies), but if fastboot wasn't working anyway then I'm good to disable it 👍 |
mydea
commented
Feb 27, 2023
Yes, there is def. more that we can do here, but this should at least unblock this for now :) |
We do not want to run the instance initializer in fastboot env, as that relies on Browser stuff.
Note that it would prob. make sense to skip all of sentry in fastboot (SSR), but that probably has to happen in user code.
This fix at least should lead to the app not failing to be served when fastboot & sentry are installed.
ref #7258