Skip to content

test(browser): Temporarily skip offline transport tests - #7305

Merged
Lms24 merged 2 commits into
developfrom
lms/tmp-skip-offline-transport-tests
Mar 1, 2023
Merged

test(browser): Temporarily skip offline transport tests#7305
Lms24 merged 2 commits into
developfrom
lms/tmp-skip-offline-transport-tests

Conversation

@Lms24

@Lms24Lms24 commented Mar 1, 2023

Copy link
Copy Markdown
Member

Unfortunately, these tests are continuously flaky so we're disabling them temporarily until the flakes are resolved.

cc @timfish when you get back :)

ref #7079

@Lms24Lms24 self-assigned this Mar 1, 2023
@Lms24
Lms24 requested review from a team, lforst and mydea and removed request for a teamMarch 1, 2023 10:22
Comment threadpackages/browser/test/unit/transports/offline.test.ts
Co-authored-by: Francesco Novy <francesco.novy@sentry.io>
@github-actions

Copy link
Copy Markdown
Contributor

Replay SDK metrics 🚀

Plain+Sentry+Replay
RevisionValueValueDiffRatioValueDiffRatio
LCPThis PR 70abc3781.75 ms66.26 ms-15.49 ms-18.95 %68.30 ms-13.45 ms-16.45 %
Previous dbd7a81116.00 ms148.94 ms+32.94 ms+28.40 %214.37 ms+98.37 ms+84.80 %
CLSThis PR 70abc370.00 ms0.00 ms0.00 ms0.00 %0.24 ms+0.23 ms+5059.44 %
Previous dbd7a810.06 ms0.06 ms-0.00 ms-0.69 %0.06 ms-0.00 ms-0.79 %
CPUThis PR 70abc3722.55 %21.89 %-0.66 pp-2.92 %38.04 %+15.49 pp+68.69 %
Previous dbd7a8127.65 %26.67 %-0.98 pp-3.55 %34.33 %+6.68 pp+24.16 %
JS heap avgThis PR 70abc373.5 MB6.74 MB+3.24 MB+92.53 %10.96 MB+7.46 MB+212.86 %
Previous dbd7a811.88 MB2.31 MB+428.27 kB+22.80 %3.52 MB+1.64 MB+87.53 %
JS heap maxThis PR 70abc373.92 MB8.18 MB+4.25 MB+108.46 %13.79 MB+9.87 MB+251.57 %
Previous dbd7a812.28 MB2.68 MB+399.08 kB+17.47 %4.1 MB+1.82 MB+79.65 %
netTxThis PR 70abc370 B333.2 kB+333.2 kBn/a106.68 kB+106.68 kBn/a
Previous dbd7a810 B0 B0 Bn/a2.23 kB+2.23 kBn/a
netRxThis PR 70abc3720.97 kB18.35 kB-2.62 kB-12.47 %20.32 kB-641 B-3.06 %
Previous dbd7a810 B0 B0 Bn/a41 B+41 Bn/a
netCountThis PR 70abc3712+1+100.00 %5+4+400.00 %
Previous dbd7a81000n/a1+1n/a
netTimeThis PR 70abc37675.11 ms528.08 ms-147.03 ms-21.78 %712.26 ms+37.15 ms+5.50 %
Previous dbd7a810.00 ms0.00 ms0.00 msn/a124.71 ms+124.71 msn/a

Previous results on branch: develop

RevisionLCPCLSCPUJS heap avgJS heap maxnetTxnetRxnetCountnetTime
dbd7a81+98.37 ms-0.00 ms+6.68 pp+1.64 MB+1.82 MB+2.23 kB+41 B+1+124.71 ms
dbd7a81+86.19 ms-0.00 ms+6.77 pp+1.58 MB+1.67 MB+2.23 kB+41 B+1+87.99 ms
67b0684+84.74 ms-0.00 ms+7.38 pp+1.7 MB+1.81 MB+2.23 kB+41 B+1+85.52 ms
4b95c04+57.56 ms-0.00 ms+7.94 pp+920.88 kB+1.05 MB+2.21 kB+41 B+1+90.32 ms
e60cd02+56.25 ms-0.00 ms+6.32 pp+927.44 kB+1.06 MB+2.21 kB+41 B+1+117.55 ms
e25c067+48.34 ms+0.00 ms+5.59 pp+926.37 kB+1.05 MB+2.22 kB+41 B+1+65.23 ms
b1b249b+43.88 ms+0.00 ms+4.80 pp+937.99 kB+1.05 MB+2.22 kB+41 B+1+111.56 ms
12e34d4+28.57 ms+0.00 ms+5.77 pp+930.12 kB+1.04 MB+2.26 kB+41 B+1+109.67 ms
c46c56c+65.45 ms-0.00 ms+5.38 pp+930.26 kB+1.07 MB+2.21 kB+41 B+1+91.29 ms
7f4c4ec+56.64 ms-0.00 ms+5.57 pp+927.42 kB+1.06 MB+2.21 kB+41 B+1+110.83 ms

*) pp - percentage points - an absolute difference between two percentages.
Last updated: Wed, 01 Mar 2023 10:46:23 GMT

@Lms24
Lms24 merged commit 3ba8e0b into developMar 1, 2023
@Lms24
Lms24 deleted the lms/tmp-skip-offline-transport-tests branch March 1, 2023 11:18
Lms24 added a commit that referenced this pull request Mar 1, 2023
Lms24 added a commit that referenced this pull request Mar 1, 2023
* Revert "test(browser): Temporarily skip offline transport tests (#7305)"
* test(core): Skip flaky offline transport test
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Lms24@mydea