Skip to content

ci: Better error handling when caches can't be restored - #7306

Merged
mydea merged 1 commit into
developfrom
fn/better-ci-cache-error
Mar 1, 2023
Merged

ci: Better error handling when caches can't be restored#7306
mydea merged 1 commit into
developfrom
fn/better-ci-cache-error

Conversation

@mydea

@mydeamydea commented Mar 1, 2023

Copy link
Copy Markdown
Member

This improves our cache restoration to actually fail if we can't restore the dependency/build cache. Without that, tests somewhat "randomly" fail, and it can be hard to figure out why.

We should now error with a more actionable message (=rerun all jobs). I extracted this into a reusable local action so we don't need to splatter this throughout the whole workflow file.

@mydea
mydea requested review from Lms24 and lforstMarch 1, 2023 10:49
@mydeamydea self-assigned this Mar 1, 2023
@mydea
mydeaforce-pushed the fn/better-ci-cache-error branch from 5bc32f7 to 61d22c2CompareMarch 1, 2023 10:56

@Lms24Lms24 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mydea

mydea commented Mar 1, 2023

Copy link
Copy Markdown
MemberAuthor

Verified that it errors out like this when the cache cannot be restored:
image

@github-actions

Copy link
Copy Markdown
Contributor

Replay SDK metrics 🚀

Plain+Sentry+Replay
RevisionValueValueDiffRatioValueDiffRatio
LCPThis PR 61405d489.22 ms76.86 ms-12.36 ms-13.86 %70.97 ms-18.25 ms-20.46 %
Previous dbd7a81116.00 ms148.94 ms+32.94 ms+28.40 %214.37 ms+98.37 ms+84.80 %
CLSThis PR 61405d40.00 ms0.00 ms0.00 ms0.00 %0.25 ms+0.25 ms+5426.18 %
Previous dbd7a810.06 ms0.06 ms-0.00 ms-0.69 %0.06 ms-0.00 ms-0.79 %
CPUThis PR 61405d425.98 %24.88 %-1.10 pp-4.25 %42.00 %+16.02 pp+61.65 %
Previous dbd7a8127.65 %26.67 %-0.98 pp-3.55 %34.33 %+6.68 pp+24.16 %
JS heap avgThis PR 61405d43.47 MB6.18 MB+2.7 MB+77.84 %9.85 MB+6.37 MB+183.44 %
Previous dbd7a811.88 MB2.31 MB+428.27 kB+22.80 %3.52 MB+1.64 MB+87.53 %
JS heap maxThis PR 61405d43.89 MB7.81 MB+3.92 MB+100.63 %13.83 MB+9.94 MB+255.46 %
Previous dbd7a812.28 MB2.68 MB+399.08 kB+17.47 %4.1 MB+1.82 MB+79.65 %
netTxThis PR 61405d40 B278.44 kB+278.44 kBn/a106.8 kB+106.8 kBn/a
Previous dbd7a810 B0 B0 Bn/a2.23 kB+2.23 kBn/a
netRxThis PR 61405d419.88 kB21.14 kB+1.26 kB+6.34 %17.52 kB-2.36 kB-11.87 %
Previous dbd7a810 B0 B0 Bn/a41 B+41 Bn/a
netCountThis PR 61405d412+1+100.00 %5+4+400.00 %
Previous dbd7a81000n/a1+1n/a
netTimeThis PR 61405d4814.91 ms958.84 ms+143.93 ms+17.66 %940.18 ms+125.27 ms+15.37 %
Previous dbd7a810.00 ms0.00 ms0.00 msn/a124.71 ms+124.71 msn/a

Previous results on branch: develop

RevisionLCPCLSCPUJS heap avgJS heap maxnetTxnetRxnetCountnetTime
dbd7a81+98.37 ms-0.00 ms+6.68 pp+1.64 MB+1.82 MB+2.23 kB+41 B+1+124.71 ms
dbd7a81+86.19 ms-0.00 ms+6.77 pp+1.58 MB+1.67 MB+2.23 kB+41 B+1+87.99 ms
67b0684+84.74 ms-0.00 ms+7.38 pp+1.7 MB+1.81 MB+2.23 kB+41 B+1+85.52 ms
4b95c04+57.56 ms-0.00 ms+7.94 pp+920.88 kB+1.05 MB+2.21 kB+41 B+1+90.32 ms
e60cd02+56.25 ms-0.00 ms+6.32 pp+927.44 kB+1.06 MB+2.21 kB+41 B+1+117.55 ms
e25c067+48.34 ms+0.00 ms+5.59 pp+926.37 kB+1.05 MB+2.22 kB+41 B+1+65.23 ms
b1b249b+43.88 ms+0.00 ms+4.80 pp+937.99 kB+1.05 MB+2.22 kB+41 B+1+111.56 ms
12e34d4+28.57 ms+0.00 ms+5.77 pp+930.12 kB+1.04 MB+2.26 kB+41 B+1+109.67 ms
c46c56c+65.45 ms-0.00 ms+5.38 pp+930.26 kB+1.07 MB+2.21 kB+41 B+1+91.29 ms
7f4c4ec+56.64 ms-0.00 ms+5.57 pp+927.42 kB+1.06 MB+2.21 kB+41 B+1+110.83 ms

*) pp - percentage points - an absolute difference between two percentages.
Last updated: Wed, 01 Mar 2023 11:16:32 GMT

@mydea
mydea merged commit a6b65c4 into developMar 1, 2023
@mydea
mydea deleted the fn/better-ci-cache-error branch March 1, 2023 11:46
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@mydea@Lms24