Skip to content

ci: Avoid continue-on-error for nextjs tests - #7308

Merged
mydea merged 1 commit into
developfrom
fn/fix-ci-failure
Mar 1, 2023
Merged

ci: Avoid continue-on-error for nextjs tests#7308
mydea merged 1 commit into
developfrom
fn/fix-ci-failure

Conversation

@mydea

@mydeamydea commented Mar 1, 2023

Copy link
Copy Markdown
Member

Not 100% sure if this will work, but it would be nice to avoid having the error logs in all CI runs:

image

Let's also see if stuff works with Node 18.14.2 again...!

@mydea
mydea requested review from Lms24 and lforstMarch 1, 2023 11:23
@mydeamydea self-assigned this Mar 1, 2023
@github-actions

Copy link
Copy Markdown
Contributor

Replay SDK metrics 🚀

Plain+Sentry+Replay
RevisionValueValueDiffRatioValueDiffRatio
LCPThis PR 3ba8e0b61.25 ms73.45 ms+12.20 ms+19.92 %72.64 ms+11.39 ms+18.60 %
Previous dbd7a81116.00 ms148.94 ms+32.94 ms+28.40 %214.37 ms+98.37 ms+84.80 %
CLSThis PR 3ba8e0b0.00 ms0.00 ms0.00 ms0.00 %0.26 ms+0.26 ms+5553.44 %
Previous dbd7a810.06 ms0.06 ms-0.00 ms-0.69 %0.06 ms-0.00 ms-0.79 %
CPUThis PR 3ba8e0b17.48 %19.51 %+2.03 pp+11.61 %36.08 %+18.59 pp+106.36 %
Previous dbd7a8127.65 %26.67 %-0.98 pp-3.55 %34.33 %+6.68 pp+24.16 %
JS heap avgThis PR 3ba8e0b3.54 MB6.91 MB+3.37 MB+95.28 %11.18 MB+7.64 MB+216.09 %
Previous dbd7a811.88 MB2.31 MB+428.27 kB+22.80 %3.52 MB+1.64 MB+87.53 %
JS heap maxThis PR 3ba8e0b3.89 MB8.29 MB+4.4 MB+113.13 %14.31 MB+10.42 MB+267.77 %
Previous dbd7a812.28 MB2.68 MB+399.08 kB+17.47 %4.1 MB+1.82 MB+79.65 %
netTxThis PR 3ba8e0b0 B360.35 kB+360.35 kBn/a105.73 kB+105.73 kBn/a
Previous dbd7a810 B0 B0 Bn/a2.23 kB+2.23 kBn/a
netRxThis PR 3ba8e0b18.13 kB18.35 kB+222 B+1.22 %18.46 kB+332 B+1.83 %
Previous dbd7a810 B0 B0 Bn/a41 B+41 Bn/a
netCountThis PR 3ba8e0b12+1+100.00 %4+3+300.00 %
Previous dbd7a81000n/a1+1n/a
netTimeThis PR 3ba8e0b601.86 ms692.68 ms+90.82 ms+15.09 %669.72 ms+67.85 ms+11.27 %
Previous dbd7a810.00 ms0.00 ms0.00 msn/a124.71 ms+124.71 msn/a

Previous results on branch: develop

RevisionLCPCLSCPUJS heap avgJS heap maxnetTxnetRxnetCountnetTime
dbd7a81+98.37 ms-0.00 ms+6.68 pp+1.64 MB+1.82 MB+2.23 kB+41 B+1+124.71 ms
dbd7a81+86.19 ms-0.00 ms+6.77 pp+1.58 MB+1.67 MB+2.23 kB+41 B+1+87.99 ms
67b0684+84.74 ms-0.00 ms+7.38 pp+1.7 MB+1.81 MB+2.23 kB+41 B+1+85.52 ms
4b95c04+57.56 ms-0.00 ms+7.94 pp+920.88 kB+1.05 MB+2.21 kB+41 B+1+90.32 ms
e60cd02+56.25 ms-0.00 ms+6.32 pp+927.44 kB+1.06 MB+2.21 kB+41 B+1+117.55 ms
e25c067+48.34 ms+0.00 ms+5.59 pp+926.37 kB+1.05 MB+2.22 kB+41 B+1+65.23 ms
b1b249b+43.88 ms+0.00 ms+4.80 pp+937.99 kB+1.05 MB+2.22 kB+41 B+1+111.56 ms
12e34d4+28.57 ms+0.00 ms+5.77 pp+930.12 kB+1.04 MB+2.26 kB+41 B+1+109.67 ms
c46c56c+65.45 ms-0.00 ms+5.38 pp+930.26 kB+1.07 MB+2.21 kB+41 B+1+91.29 ms
7f4c4ec+56.64 ms-0.00 ms+5.57 pp+927.42 kB+1.06 MB+2.21 kB+41 B+1+110.83 ms

*) pp - percentage points - an absolute difference between two percentages.
Last updated: Wed, 01 Mar 2023 11:33:55 GMT

@mydea
mydea marked this pull request as ready for review March 1, 2023 11:49
@mydea
mydea merged commit 73a1bbb into developMar 1, 2023
@mydea
mydea deleted the fn/fix-ci-failure branch March 1, 2023 11:50
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@mydea@lforst