Uh oh!
There was an error while loading. Please reload this page.
feat(replay): Update rrweb to 1.105.0 & add breadcrumb when encountering large mutation#7314
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -198,6 +198,23 @@ export class ReplayContainer implements ReplayContainerInterface { | ||
| // instead, we'll always keep the last 60 seconds of replay before an error happened | ||
| ...(this.recordingMode === 'error' && { checkoutEveryNms: ERROR_CHECKOUT_TIME }), | ||
| emit: this._handleRecordingEmit, | ||
| onMutation: (mutations: unknown[]) => { | ||
| if (this._options._experiments.captureMutationSize) { | ||
| const count = mutations.length; | ||
| if (count > 500) { | ||
| const breadcrumb = createBreadcrumb({ | ||
| category: 'replay.mutations', | ||
| data: { | ||
| count, | ||
| }, | ||
| }); | ||
| this._createCustomBreadcrumb(breadcrumb); | ||
| } | ||
| } | ||
| // `true` means we use the regular mutation handling by rrweb | ||
| return true; | ||
Member There was a problem hiding this comment. Maybe add a comment on why we return true here? MemberAuthor There was a problem hiding this comment. Just to be sure, will this be shown in the UI automatically or does that need changes in the UI to be reflected? Member There was a problem hiding this comment. Hmm let me double check the breadcrumbs, iirc we just display them all Member There was a problem hiding this comment. OK so we have 2 options here: 1) we let UI handle the messaging, or 2) we let SDK handle messaging. The logic goes like this... if we have Let's make this a bit more dumb and have the UI determine how it's displayed (since it's easier for us to update the UI). This also means we will need to make the UI update first. I'm also thinking if we should only display these crumbs (in the UI) for Sentry internal users only at first - I'm worried this breadcrumb may confuse users? Member There was a problem hiding this comment.
If we limit it to sentry-internal, let's at least give users a way to opt-in ( MemberAuthor There was a problem hiding this comment. Good point - I'll add an mydea marked this conversation as resolved.
Uh oh!There was an error while loading. Please reload this page. | ||
| }, | ||
| }); | ||
| } catch (err) { | ||
| this._handleException(err); | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you should be able to
import {mutationRecord} from '@sentry-internal/rrweb'There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO we can leave this as unknown as we really don't care about what type of array that is (for now), one less import to care about 😅