Uh oh!
There was an error while loading. Please reload this page.
fix(tracing): Record LCP and CLS on transaction finish - #7386
Merged
Conversation
AbhiPrasad
marked this pull request as ready for review
March 8, 2023 17:28
Contributor
size-limit report 📦
|
k-fish
approved these changes
Mar 8, 2023
Comment on lines
+43
to
+45
| _trackCLS(); | ||
| _trackLCP(); | ||
| _trackFID(); | ||
| return _trackLCP(); |
Member
There was a problem hiding this comment.
Does CLS also have a stop listen? we should be returning all of them in a wrapper function and just settling them whenever we finish the transaction
ContributorAuthor
There was a problem hiding this comment.
yeah that makes sense to me, will make the change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes#7341
To get better LCP and CLS accuracy, let's fire the
stopListeningfunc on transaction finish.