Skip to content

fix(replay): Never capture file input changes - #7485

Merged
mydea merged 2 commits into
developfrom
fn/replay-ignore-files
Mar 20, 2023
Merged

fix(replay): Never capture file input changes#7485
mydea merged 2 commits into
developfrom
fn/replay-ignore-files

Conversation

@mydea

Copy link
Copy Markdown
Member

IMHO we can just ignore all change events for file inputs, that should be OK I'd say?

Closesgetsentry/rrweb#80

@mydea
mydea requested a review from billyvgMarch 16, 2023 13:13
@mydeamydea self-assigned this Mar 16, 2023
@github-actions

github-actionsBot commented Mar 16, 2023

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
@sentry/browser - ES5 CDN Bundle (gzipped + minified)20.46 KB (-0.01% 🔽)
@sentry/browser - ES5 CDN Bundle (minified)63.38 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified)19.07 KB (-0.01% 🔽)
@sentry/browser - ES6 CDN Bundle (minified)56.43 KB (0%)
@sentry/browser - Webpack (gzipped + minified)21.65 KB (0%)
@sentry/browser - Webpack (minified)71.97 KB (0%)
@sentry/react - Webpack (gzipped + minified)21.68 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified)52.02 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified)33.75 KB (-0.01% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified)26.1 KB (0%)
@sentry/replay ES6 CDN Bundle (gzipped + minified)43.87 KB (+0.03% 🔺)
@sentry/replay - Webpack (gzipped + minified)37.95 KB (+0.04% 🔺)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified)62.07 KB (+0.03% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified)55.14 KB (+0.03% 🔺)

@mydea
mydeaforce-pushed the fn/replay-ignore-files branch 2 times, most recently from 0ec91e1 to b46d648CompareMarch 16, 2023 14:40

@billyvgbillyvg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mydea
mydeaforce-pushed the fn/replay-ignore-files branch from b46d648 to 19226e7CompareMarch 17, 2023 07:58
@mydea
mydeaforce-pushed the fn/replay-ignore-files branch from 19226e7 to 7ae28feCompareMarch 17, 2023 13:22
@mydea
mydea merged commit 86cd7fd into developMar 20, 2023
@mydea
mydea deleted the fn/replay-ignore-files branch March 20, 2023 08:22
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mutations are capturing file uploads

2 participants

@mydea@billyvg