Skip to content

fix(integrations): Handle lower-case prefix windows paths in RewriteFrames - #7506

Merged
Lms24 merged 1 commit into
developfrom
lms/fix-rewriteframes-windows-regex
Mar 20, 2023
Merged

fix(integrations): Handle lower-case prefix windows paths in RewriteFrames#7506
Lms24 merged 1 commit into
developfrom
lms/fix-rewriteframes-windows-regex

Conversation

@Lms24

Copy link
Copy Markdown
Member

Our previous regex to rewrite windows file paths in stack frames didn't match lower-case c:\\ prefixes. This PR fixes that.

closes#7499

@Lms24
Lms24 requested review from AbhiPrasad and mydeaMarch 17, 2023 13:48
@github-actions

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
@sentry/browser - ES5 CDN Bundle (gzipped + minified)20.49 KB (+0.18% 🔺)
@sentry/browser - ES5 CDN Bundle (minified)63.56 KB (+0.3% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped + minified)19.11 KB (+0.24% 🔺)
@sentry/browser - ES6 CDN Bundle (minified)56.63 KB (+0.36% 🔺)
@sentry/browser - Webpack (gzipped + minified)21.68 KB (+0.17% 🔺)
@sentry/browser - Webpack (minified)72.17 KB (+0.28% 🔺)
@sentry/react - Webpack (gzipped + minified)21.72 KB (+0.18% 🔺)
@sentry/nextjs Client - Webpack (gzipped + minified)52.06 KB (+0.07% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified)33.78 KB (+0.11% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified)26.14 KB (+0.13% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified)44 KB (+0.33% 🔺)
@sentry/replay - Webpack (gzipped + minified)38.07 KB (+0.35% 🔺)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified)62.22 KB (+0.27% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified)55.3 KB (+0.33% 🔺)

@Lms24Lms24 mentioned this pull request Mar 17, 2023
3 tasks
@Lms24
Lms24 merged commit 45692f4 into developMar 20, 2023
@Lms24
Lms24 deleted the lms/fix-rewriteframes-windows-regex branch March 20, 2023 10:18
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failed to rewrite frame

2 participants

@Lms24@AbhiPrasad