Skip to content

ref(sveltekit): Rewrite sentryHandle using trace func - #7559

Merged
AbhiPrasad merged 2 commits into
developfrom
abhi-sentry-handle-trace-func
Mar 22, 2023
Merged

ref(sveltekit): Rewrite sentryHandle using trace func#7559
AbhiPrasad merged 2 commits into
developfrom
abhi-sentry-handle-trace-func

Conversation

@AbhiPrasad

@AbhiPrasadAbhiPrasad commented Mar 21, 2023

Copy link
Copy Markdown
Contributor

Rewrite the handle function wrapper using the trace function introduced in #7556

@github-actions

github-actionsBot commented Mar 21, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
@sentry/browser - ES5 CDN Bundle (gzipped + minified)20.44 KB (-0.01% 🔽)
@sentry/browser - ES5 CDN Bundle (minified)63.52 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified)19.13 KB (+0.01% 🔺)
@sentry/browser - ES6 CDN Bundle (minified)56.57 KB (0%)
@sentry/browser - Webpack (gzipped + minified)21.59 KB (0%)
@sentry/browser - Webpack (minified)71.65 KB (+0.01% 🔺)
@sentry/react - Webpack (gzipped + minified)21.61 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified)51.85 KB (-0.21% 🔽)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified)27.77 KB (+0.06% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified)26.08 KB (+0.07% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified)44.21 KB (+0.01% 🔺)
@sentry/replay - Webpack (gzipped + minified)38.28 KB (0%)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified)62.4 KB (+0.03% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified)55.95 KB (0%)

Base automatically changed from abhi-trace-func to developMarch 22, 2023 10:40
@AbhiPrasad
AbhiPrasadforce-pushed the abhi-sentry-handle-trace-func branch from a9908ef to 3bfb9f7CompareMarch 22, 2023 11:00
@AbhiPrasad
AbhiPrasad requested a review from Lms24March 22, 2023 11:01
@AbhiPrasad
AbhiPrasad marked this pull request as ready for review March 22, 2023 11:01
Lms24
Lms24 approved these changes Mar 22, 2023
View reviewed changes

@Lms24Lms24 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much cleaner!

@AbhiPrasad
AbhiPrasad enabled auto-merge (squash) March 22, 2023 14:03
@AbhiPrasad
AbhiPrasad merged commit d265fe5 into developMar 22, 2023
@AbhiPrasad
AbhiPrasad deleted the abhi-sentry-handle-trace-func branch March 22, 2023 14:22
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lms24Lms24Lms24 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AbhiPrasad@Lms24